summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-10-02Bump version to 0.3.2.2-alpha.Alexander Færøy
Signed-off-by: Isis Lovecruft <isis@torproject.org>
2017-10-02Remove changes files integrated for 0.3.2.2-alpha.Isis Lovecruft
2017-09-29ChangeLog additions for 0.3.2.2-alpha.Isis Lovecruft
2017-09-29Merge remote-tracking branch 'dgoulet/ticket23696_032_01'Nick Mathewson
2017-09-29changes tweak.Nick Mathewson
2017-09-29Merge branches 'bug8185_031' and 'bug8185_diagnostic_032'Nick Mathewson
2017-09-29sched: Always initialize scheduler_last_run to nowDavid Goulet
Because our monotonic time interface doesn't play well with value set to 0, always initialize to now() the scheduler_last_run at init() of the KIST scheduler. Fixes #23696 Signed-off-by: David Goulet <dgoulet@torproject.org>
2017-09-29sched: Don't get KIST stuck in an infinite loopMatt Traudt
When a channel is scheduled and flush cells returns 0 that is no cells to flush, we flag it back in waiting for cells so it doesn't get stuck in a possible infinite loop. It has been observed on moria1 where a closed channel end up in the scheduler where the flush process returned 0 cells but it was ultimately kept in the scheduling loop forever. We suspect that this is due to a more deeper problem in tor where the channel_more_to_flush() is actually looking at the wrong queue and was returning 1 for an empty channel thus putting the channel in the "Case 4" of the scheduler which is to go back in pending state thus re-considered at the next iteration. This is a fix that allows the KIST scheduler to recover properly from a not entirelly diagnosed problem in tor. Fixes #23676 Signed-off-by: David Goulet <dgoulet@torproject.org>
2017-09-29Merge branch 'bug23690_additional_032'Nick Mathewson
2017-09-29Make some assertions nonfatal to help prevent bug23690 recurrence.Nick Mathewson
2017-09-29Merge branch 'bug23690_028'Nick Mathewson
2017-09-29Clear outbuf_flushlen when we clear a connection's outbufNick Mathewson
When we added single_conn_free_bytes(), we cleared the outbuf on a connection without setting outbuf_flushlen() to 0. This could cause an assertion failure later on in flush_buf(). Fixes bug 23690; bugfix on 0.2.6.1-alpha.
2017-09-29Merge branch 'bug8185_025' into bug8185_031Nick Mathewson
2017-09-29Don't package cells onto marked circuits.Nick Mathewson
This caused a BUG log when we noticed that the circuit had no channel. The likeliest culprit for exposing that behavior is d769cab3e5097980, where we made circuit_mark_for_close() NULL out the n_chan and p_chan fields of the circuit. Fixes bug 8185; bugfix on 0.2.5.4-alpha, I think.
2017-09-29Log more information when bug8185 is about to trigger.Nick Mathewson
My current theory is that this is just a marked circuit that hasn't closed yet, but let's gather more information in case that theory is wrong. Diagnostic for 8185.
2017-09-28Merge remote-tracking branch 'catalyst-oniongit/bug23691'Nick Mathewson
2017-09-28Merge remote-tracking branch 'ahf-gitlab/bugs/23551'Nick Mathewson
2017-09-28Merge branch 'maint-0.3.1'Nick Mathewson
2017-09-28Fix leak in test_util.cTaylor Yu
AddressSanitizer found a leak in test_util_decompress_dos_impl(). Fixes bug #23691.
2017-09-28Merge remote-tracking branch 'ahf-gitlab/bugs/23551-maint-0.3.1' into ↵Nick Mathewson
maint-0.3.1
2017-09-28Better error handling when trying to compress/decompress into empty buffer.Alexander Færøy
This patch ensures that we return TOR_COMPRESS_BUFFER_FULL in case we have a input bytes left to process, but are out of output buffer or in case we need to finish where the compression implementation might need to write an epilogue. See: https://bugs.torproject.org/23551
2017-09-28Enable disabled test that was disabled due to bug #23551Alexander Færøy
See: https://bugs.torproject.org/23551
2017-09-28Better error handling when trying to compress/decompress into empty buffer.Alexander Færøy
This patch ensures that we return TOR_COMPRESS_BUFFER_FULL in case we have a input bytes left to process, but are out of output buffer or in case we need to finish where the compression implementation might need to write an epilogue. See: https://bugs.torproject.org/23551
2017-09-28Fix whitespace issue in compress.cAlexander Færøy
2017-09-28Fix typo in buffers.c.Alexander Færøy
2017-09-28Improve unit test coverage for compression code.Nick Mathewson
These tests try uncompressing garbage, verify that we won't make compression bombs, and verify that we won't uncompress compression bombs.
2017-09-28Fix spelling: compressing, not compresingNick Mathewson
2017-09-28Unit test for case where %included dir exists but is unreadableNick Mathewson
2017-09-28unit test for config_lines_dup_and_filterNick Mathewson
2017-09-28Correct docs for config_lines_dup_and_filterNick Mathewson
2017-09-28Move around some LCOV_EXCLs in src/commonNick Mathewson
Apparently, my compiler now generates coverage markers for label-only lines, so we need to exclude those too if they are meant to be unreachable.
2017-09-28Improve cov-diff script to account for new files.Nick Mathewson
2017-09-28Add unit test for buf_get_line().Nick Mathewson
2017-09-28Note an unreachable (?) section in buffers.cNick Mathewson
2017-09-27Let's get 100% coverage for proto_http while we're at it.Nick Mathewson
There was some coverage before, but it was mostly accidental.
2017-09-27Test more error cases of our socks code.Nick Mathewson
Coverage is now respectable. :)
2017-09-27Add unit tests for SOCKS functions that parse server responsesNick Mathewson
We use these when we're acting as a SOCKS client, but we'd never actually written tests for them :/
2017-09-27socks5 unit tests: add check for ipv6 address type.Nick Mathewson
2017-09-27Socks tests for bad socks5 username/passwd auth.Nick Mathewson
2017-09-27Mark some tests in parse_socks.c as unreachable (BUG, LCOV)Nick Mathewson
These tests aren't reachable, given their actual arguments. I'm going to mark them as BUG(), and as unreachable with LCOV.
2017-09-27testing: test many possible truncated SOCKS commandsNick Mathewson
Many of the 'truncated command' paths in fetch_from_buf_socks() were not reached by the tests. This new unit test tries to check them exhaustively.
2017-09-27Move ext_or_command tests to test_proto_misc.cNick Mathewson
No other code changes.
2017-09-27Add unit tests for var_cell and control0 proto functions.Nick Mathewson
2017-09-26Eat redundant semicolonsTaylor Yu
2017-09-26fix the changes fileNick Mathewson
2017-09-26hs-v3: Don't non fatal assert if we can't get the intro extend infoDavid Goulet
Fixes #23159. Signed-off-by: David Goulet <dgoulet@torproject.org>
2017-09-26Merge branch 'ticket23602_029'Nick Mathewson
2017-09-26Merge branch 'typecheck4'Nick Mathewson
2017-09-26changes file for my confparse typechecking funNick Mathewson
2017-09-26Type bug in shared_random_state -- make sure Version is int.Nick Mathewson
The confparse field has type UINT, which corresponds to an int type. We had uint32_t. This shouldn't cause trouble in practice, since int happens to 4-bytes wide on every platform where an authority is running. It's still wrong, though.
7apu2bq3rhoylwmucxizk54afw5jyda7pho4j5zdcqpwkufke7zdzwad.onion