aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-10-18test: Add test for closing intro circuits when storing a new descriptorDavid Goulet
This is client side and related to 27471 for previous commit that fixes this issue. Signed-off-by: David Goulet <dgoulet@torproject.org>
2018-10-18hs-v3: Close client intro circuits if the descriptor is replacedDavid Goulet
When storing a descriptor in the client cache, if we are about to replace an existing descriptor, make sure to close every introduction circuits of the old descriptor so we don't have leftovers lying around. Ticket 27471 describes a situation where tor is sending an INTRODUCE1 cell on an introduction circuit for which it doesn't have a matching intro point object (taken from the descriptor). The main theory is that, after a new descriptor showed up, the introduction points changed which led to selecting an introduction circuit not used by the service anymore thus for which we are unable to find the corresponding introduction point within the descriptor we just fetched. Closes #27471. Signed-off-by: David Goulet <dgoulet@torproject.org>
2018-10-18Merge branch 'maint-0.3.4' into maint-0.3.5Nick Mathewson
2018-10-18Merge branch 'maint-0.3.3' into maint-0.3.4Nick Mathewson
2018-10-17Merge branch 'bug27800-034' into bug27800-035Taylor Yu
2018-10-17Merge branch 'bug27800-033' into tor-034Taylor Yu
2018-10-17Log more info for duplicate ed25519 IDsTaylor Yu
Occasionally, key pinning doesn't catch a relay that shares an ed25519 ID with another relay. Log the identity fingerprints and the shared ed25519 ID when this happens, instead of making a BUG() warning. Fixes bug 27800; bugfix on 0.3.2.1-alpha.
2018-10-17Bump to 0.3.5.3-alpha-devNick Mathewson
2018-10-17expand the blurbtor-0.3.5.3-alphaNick Mathewson
2018-10-17Reflow the changelogNick Mathewson
2018-10-17merge in some fixes i found in a sandboxRoger Dingledine
2018-10-170.3.5.3-alpha changelog touch-upsRoger Dingledine
2018-10-17Fold in the entry for 28089Nick Mathewson
2018-10-17Merge branch 'maint-0.3.4'Nick Mathewson
2018-10-17conn: Stop writing when our write bandwidth limist is exhaustedDavid Goulet
Commit 488e2b00bf881b97bcc8e4bbe304845ff1d79a03 introduced an issue, most likely introduced by a bad copy paste, that made us stop reading on the connection if our write bandwidth limit was reached. The problem is that because "read_blocked_on_bw" was never set, the connection was never reenabled for reading. This is most likely the cause of #27813 where bytes were accumulating in the kernel TCP bufers because tor was not doing reads. Only relays with RelayBandwidthRate would suffer from this but affecting all relays connecting to them. And using that tor option is recommended and best practice so many many relays have it enabled. Fixes #28089.
2018-10-17Light changelog editsNick Mathewson
2018-10-17Bump to 0.3.5.3-alphaNick Mathewson
2018-10-17Run format-changelogNick Mathewson
2018-10-17Fold changes file into changelogNick Mathewson
2018-10-16Merge remote-tracking branch 'tor-github/pr/406'Nick Mathewson
2018-10-16Merge remote-tracking branch 'tor-github/pr/408'Nick Mathewson
2018-10-16Argh. The unset value for OwningControllerFD is NOT -1.Nick Mathewson
2018-10-16Merge branch 'bug27849_redux'Nick Mathewson
2018-10-16Merge remote-tracking branch 'tor-github/pr/404'Nick Mathewson
2018-10-16Add a tor_free() in tor_gencert to fix a coverity warningNick Mathewson
2018-10-16Fix typo in comment for hs_cell_parse_introduce2()Neel Chauhan
2018-10-16mainloop: Set client role if ControlPort is setDavid Goulet
It turns out that if _only_ the ControlPort is set and nothing else, tor would simply not bootstrap and thus not start properly. Commit 67a41b63063370c2 removed that requirement for tor to be considered a "client". Unfortunately, this made the mainloop enable basically nothing if only the ControlPort is set in the torrc. This commit now makes it that we also consider the ControlPort when deciding if we are a Client or not. It does not revert 67a41b63063370c2 meaning options_any_client_port_set() stays the same, not looking at the control port. Fixes #27849. Signed-off-by: David Goulet <dgoulet@torproject.org>
2018-10-16Merge branch 'maint-0.3.4'Nick Mathewson
2018-10-16test: Update approx_time before the test startsDavid Goulet
This way we have the same time source when the IP is created and tested later. Fixes #27810 Signed-off-by: David Goulet <dgoulet@torproject.org>
2018-10-16Merge remote-tracking branch 'public/bug27990'Nick Mathewson
2018-10-15Merge branch 'maint-0.3.4'Nick Mathewson
2018-10-15Merge branch 'maint-0.3.3' into maint-0.3.4Nick Mathewson
2018-10-15Fix another tor_assert(0) caseNick Mathewson
2018-10-15Merge branch 'maint-0.3.4'Nick Mathewson
2018-10-15Merge branch 'maint-0.3.3' into maint-0.3.4Nick Mathewson
2018-10-15Merge branch 'maint-0.2.9' into maint-0.3.3Nick Mathewson
2018-10-15Fix make check-spaces.Nick Mathewson
2018-10-15Merge branch 'maint-0.3.4'Nick Mathewson
2018-10-15Merge branch 'maint-0.3.3' into maint-0.3.4Nick Mathewson
2018-10-15Adjust tor_assert_unreached()Nick Mathewson
This version of the macro makes it obvious to the compiler that "tor_assert_unreached()" will always abort().
2018-10-15Merge branch 'maint-0.3.4'Nick Mathewson
2018-10-15Merge branch 'maint-0.3.3' into maint-0.3.4Nick Mathewson
2018-10-15Merge branch 'maint-0.2.9' into maint-0.3.3Nick Mathewson
2018-10-15Merge branch 'bug27709_029' into maint-0.2.9Nick Mathewson
2018-10-15Explain a bit more about branch prediction in the unit-test caseNick Mathewson
2018-10-15Write a comment to explain may_need_rebind conditionrl1987
2018-10-15Refrain from listener rebinding when address families differrl1987
2018-10-14Remove a double-newline and improve a commentNick Mathewson
2018-10-14Merge branch 'bug27772_squashed'Nick Mathewson
2018-10-14Fix various GCC LTO warnings in the unit tests.Nick Mathewson
7apu2bq3rhoylwmucxizk54afw5jyda7pho4j5zdcqpwkufke7zdzwad.onion