aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2010-10-20Merge remote branch 'origin/maint-0.2.2'Nick Mathewson
Conflicts: src/or/networkstatus.c
2010-10-20Fix a logic error in 98aee84. Found by boboperNick Mathewson
2010-10-20Merge remote branch 'origin/maint-0.2.2'Nick Mathewson
Conflicts: src/or/networkstatus.c
2010-10-20Add a ! to directory_caches_dir_info() to fix a logic errorNick Mathewson
We want to fetch directory info more aggressively if we need it to refuseunknownexits. Thus, we'll want it if our exit policy is _NOT_ reject *.
2010-10-20Merge branch 'bug2097' into maint-0.2.2Nick Mathewson
2010-10-20Fix a read of a freed pointer while in set_current_consensusNick Mathewson
Found by rransom while working on issue #988. Bugfix on 0.2.2.17-alpha. Fixes bug 2097.
2010-10-20Merge remote branch 'origin/maint-0.2.2'Nick Mathewson
2010-10-20Remove redundant -Wpointer-sign CFLAGSebastian Hahn
-Wpointer-sign is implied with -Wall, which we use when building with --enable-gcc-warnings.
2010-10-20Remove redundant -Wformat -Wformat-security CFLAGSSebastian Hahn
When configuring with --enable-gcc-warnings, we use -Wformat=2 which automatically enables the available -Wformat switches, so adding them again in the --enable-gcc-hardening case doesn't make sense..
2010-10-20Use ssp-buffer-size param when hardeningSebastian Hahn
We used to enable ssp-buffer-size=1 only when building with --enable-gcc-warnings. That would result in warnings (and no protection for small arrays) when building with --enable-gcc-hardening without enabling warnings, too. Fixes bug 2031. Also remove an XXX: We now allow to build with -fstack-protector by using --enable-gcc-hardening.
2010-10-15clarify fmt_addr32 documentation to note that the address is in host-orderNick Mathewson
2010-10-15Fix one-time memory leak when initializing libevent. Spotted by SebastianNick Mathewson
2010-10-15Merge branch 'bug1992_part1'Nick Mathewson
2010-10-15Tweak the fmt_addr32 codeNick Mathewson
Clarify documentation, rename a local, and fix a memory leak.
2010-10-15Remove more unused code from routerlist.cNick Mathewson
2010-10-15Remove an unused field from circ_buffer_stats_tNick Mathewson
2010-10-15Improve accuracy of comment about aes_crypt performanceNick Mathewson
The old comment was from before I tried a huge pile of crazy stuff to make the inner loop faster. Short answer: GCC already knows how to unroll loops pretty well. Other short answer: we should have made the relay payload size an even multiple of 4, 8, or ideally 16.
2010-10-15Fix a documention issue in circuitlist.cNick Mathewson
2010-10-15Kill comments saying to remove asserts once bug930 is solved.Nick Mathewson
It's okay to leave the asserts in: the code doesn't appear in profiles.
2010-10-15fix another typoRoger Dingledine
2010-10-15Fix an apostrophe in a commentNick Mathewson
2010-10-15Fold timestamp_created into highres_createdNick Mathewson
There's no reason to keep a time_t and a struct timeval to represent the same value: highres_created.tv_sec was the same as timestamp_created. This should save a few bytes per circuit.
2010-10-15Add a portable tor_timercmpNick Mathewson
We can't use the platform timercmp, because 1) some platforms don't have them 2) some that do have them only support certain relational operators
2010-10-15Remove XXXs about improving buf_t API: bufferevents are the futureNick Mathewson
2010-10-15Make the return value of tor_addr_sockaddr always be signedNick Mathewson
2010-10-15Remove "is this too slow?" XXXX comments for code not appearing in profilesNick Mathewson
2010-10-15Remove the unused old fuzzy-time codeNick Mathewson
2010-10-15Fix an xxx wrt picking libevent methods known-to-workNick Mathewson
The short version is, "where we want to do it, we have nothing real to chose from and we can't do it easily. Where it's easy to do, we have no reason to do it yet."
2010-10-15Remove an XXX in ntmain.c: a simple function call per loop is not so expensive.Nick Mathewson
2010-10-15Raise libevent version needed for buffereventsSebastian Hahn
2010-10-14Make check-spaces happySebastian Hahn
2010-10-14Rename router_get_by_digest()Sebastian Hahn
We now call the function router_get_by_id_digest() to make clear that we're talking about the identity digest here, not descriptor digest.
2010-10-13Fix a few trivial bugs from the nodelist mergeNick Mathewson
2010-10-13Fix some XXXXs in connection_add_impl related to bufferevent error checkingNick Mathewson
This might make bufferevents more asserty for a while, but they should make other bugs less likely to go unnoticed. Noted by Sebastian.
2010-10-13Fix a couple users of buf_datalen that slipped in. Found by SebastianNick Mathewson
2010-10-13Implement node_set_exit_policy_to_reject_all with a flagNick Mathewson
Also remove some debugging code.
2010-10-13Merge remote branch 'arma/bug1982_2'Nick Mathewson
Resolved a minor conflict in: src/or/circuitbuild.c
2010-10-13Merge branch 'nodes'Nick Mathewson
2010-10-13Send END cells on bufferevent tunneled directory connsNick Mathewson
Our old code correctly called bufferevent_flush() on linked connections to make sure that the other side got an EOF event... but it didn't call bufferevent_flush() when the connection wasn't hold_open_until_flushed. Directory connections don't use hold_open_until_flushed, so the linked exit connection never got an EOF, so they never sent a RELAY_END cell to the client, and the client never concluded that data had arrived. The solution is to make the bufferevent_flush() code apply to _all_ closing linked conns whose partner is not already marked for close.
2010-10-13Revert accidentally-committed changes to routerlist.cNick Mathewson
This reverts part of commit a0c1c2ac012fded493c0d8c49fe57e56373b061f.
2010-10-13Use connection_mark_and_flush consistently.Nick Mathewson
2010-10-12Remember to re-install inbuf/outbuf callbacks on ssl buffereventsNick Mathewson
If we don't, we will (among other bad things) never update lastread/lastwritten, and so flood the network with keepalives.
2010-10-12Set OpenSSL 0.9.8l renegotiation flag early enough for buffereventsNick Mathewson
This seems to fix another case of bug2001.
2010-10-12Actually call connection_tls_finish_handshake() with buffereventsNick Mathewson
First start of a fix for bug2001, but my test network still isn't working: the client and the server send each other VERSIONS cells, but never notice that they got them.
2010-10-12Merge remote branch 'origin/maint-0.2.2'Nick Mathewson
2010-10-11Fix running unit tests from outside of the build directory (fixes bug #2051)Steven Murdoch
Currently the unit tests test_util_spawn_background_* assume that they are run from the Tor build directory. This is not the case when running make distcheck, so the test will fail. This problem is fixed by autoconf setting BUILDDIR to be the root of the Tor build directory, and this preprocessor variable being used to specify the absolute path to test-child. Also, in test-child, do not print out argv[0] because this will no longer be predictable. Found by Sebastian Hahn.
2010-10-11Add header for tor_tls_log_one_errorNick Mathewson
2010-10-11Log OpenSSL errors coming from bufferevent_opensslNick Mathewson
2010-10-11Fix MIPSpro and time_t signedness detectionSebastian Hahn
3d6e2830876 silenced the autogen.sh warnings as it was supposed to, but introduced two bugs. Fix them.
2010-10-11Fix the new warnings during autogen.shSebastian Hahn
Follow-up fix to 3d6e2830876c for configure.in additions in master that weren't in maint-0.2.2