summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--changes/bug300017
-rw-r--r--src/feature/dircache/dircache.c2
-rw-r--r--src/test/test_dir_handle_get.c2
3 files changed, 9 insertions, 2 deletions
diff --git a/changes/bug30001 b/changes/bug30001
new file mode 100644
index 0000000000..52e58872ef
--- /dev/null
+++ b/changes/bug30001
@@ -0,0 +1,7 @@
+ o Minor features (testing):
+ - Use the approx_time() function when setting the "Expires" header
+ in directory replies, to make them more testable. Needed for
+ ticket 30001.
+ o Minor bug fixes (testing):
+ - Check the time in the "Expires" header with approx_time().
+ Fixes bug 30001; bugfix on 0.4.0.4-rc.
diff --git a/src/feature/dircache/dircache.c b/src/feature/dircache/dircache.c
index 06bd298aca..1b36f716f4 100644
--- a/src/feature/dircache/dircache.c
+++ b/src/feature/dircache/dircache.c
@@ -124,7 +124,7 @@ write_http_response_header_impl(dir_connection_t *conn, ssize_t length,
long cache_lifetime)
{
char date[RFC1123_TIME_LEN+1];
- time_t now = time(NULL);
+ time_t now = approx_time();
buf_t *buf = buf_new_with_capacity(1024);
tor_assert(conn);
diff --git a/src/test/test_dir_handle_get.c b/src/test/test_dir_handle_get.c
index c3a17e7309..e57bd02584 100644
--- a/src/test/test_dir_handle_get.c
+++ b/src/test/test_dir_handle_get.c
@@ -2526,7 +2526,7 @@ test_dir_handle_get_status_vote_next_bandwidth(void* data)
/* Check cache lifetime */
char expbuf[RFC1123_TIME_LEN+1];
- time_t now = time(NULL);
+ time_t now = approx_time();
/* BANDWIDTH_CACHE_LIFETIME is defined in dircache.c. */
format_rfc1123_time(expbuf, (time_t)(now + 30*60));
char *expires = NULL;