summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--changes/ticket248493
-rw-r--r--src/or/dirvote.c8
2 files changed, 10 insertions, 1 deletions
diff --git a/changes/ticket24849 b/changes/ticket24849
new file mode 100644
index 0000000000..fd9492acb9
--- /dev/null
+++ b/changes/ticket24849
@@ -0,0 +1,3 @@
+ o Minor features (directory authority):
+ - When unable to add signatures to a pending consensus, log the reason
+ why. Closes ticket 24849.
diff --git a/src/or/dirvote.c b/src/or/dirvote.c
index ce82a5ef4a..e57f6d46f8 100644
--- a/src/or/dirvote.c
+++ b/src/or/dirvote.c
@@ -3551,7 +3551,13 @@ dirvote_add_signatures_to_pending_consensus(
}
r = networkstatus_add_detached_signatures(pc->consensus, sigs,
source, severity, msg_out);
- log_info(LD_DIR,"Added %d signatures to consensus.", r);
+ if (r >= 0) {
+ log_info(LD_DIR,"Added %d signatures to consensus.", r);
+ } else {
+ log_fn(LOG_PROTOCOL_WARN, LD_DIR,
+ "Unable to add signatures to consensus: %s",
+ *msg_out ? *msg_out : "(unknown)");
+ }
if (r >= 1) {
char *new_signatures =