diff options
| -rw-r--r-- | changes/ticket20241 | 3 | ||||
| -rw-r--r-- | configure.ac | 1 | ||||
| -rw-r--r-- | src/common/compat_pthreads.c | 19 | ||||
| -rw-r--r-- | src/common/crypto.c | 3 |
4 files changed, 20 insertions, 6 deletions
diff --git a/changes/ticket20241 b/changes/ticket20241 new file mode 100644 index 0000000000..7c592f7367 --- /dev/null +++ b/changes/ticket20241 @@ -0,0 +1,3 @@ + o Minor features (compilation, portability): + - Tor now compiles correctly on MacOS 10.12 (aka "Sierra"). Closes + ticket 20241. diff --git a/configure.ac b/configure.ac index 4c9b1f6036..f6edb3a513 100644 --- a/configure.ac +++ b/configure.ac @@ -999,6 +999,7 @@ AC_CHECK_HEADERS([assert.h \ sys/mman.h \ sys/param.h \ sys/prctl.h \ + sys/random.h \ sys/resource.h \ sys/select.h \ sys/socket.h \ diff --git a/src/common/compat_pthreads.c b/src/common/compat_pthreads.c index 79f5cec43a..c1ae66c1d2 100644 --- a/src/common/compat_pthreads.c +++ b/src/common/compat_pthreads.c @@ -200,14 +200,21 @@ tor_cond_init(tor_cond_t *cond) return -1; } -#if defined(HAVE_CLOCK_GETTIME) && defined(CLOCK_MONOTONIC) \ - && defined(HAVE_PTHREAD_CONDATTR_SETCLOCK) +#if defined(HAVE_CLOCK_GETTIME) +#if defined(CLOCK_MONOTONIC) && defined(HAVE_PTHREAD_CONDATTR_SETCLOCK) /* Use monotonic time so when we timedwait() on it, any clock adjustment * won't affect the timeout value. */ if (pthread_condattr_setclock(&condattr, CLOCK_MONOTONIC)) { return -1; } -#endif +#define USE_COND_CLOCK CLOCK_MONOTONIC +#else /* !defined HAVE_PTHREAD_CONDATTR_SETCLOCK */ + /* On OSX Sierra, there is no pthread_condattr_setclock, so we are stuck + * with the realtime clock. + */ +#define USE_COND_CLOCK CLOCK_REALTIME +#endif /* which clock to use */ +#endif /* HAVE_CLOCK_GETTIME */ if (pthread_cond_init(&cond->cond, &condattr)) { return -1; } @@ -252,12 +259,12 @@ tor_cond_wait(tor_cond_t *cond, tor_mutex_t *mutex, const struct timeval *tv) struct timeval tvnow, tvsum; struct timespec ts; while (1) { -#if defined(HAVE_CLOCK_GETTIME) && defined(CLOCK_MONOTONIC) - if (clock_gettime(CLOCK_MONOTONIC, &ts) < 0) { +#if defined(HAVE_CLOCK_GETTIME) && defined(USE_COND_CLOCK) + if (clock_gettime(USE_COND_CLOCK, &ts) < 0) { return -1; } tvnow.tv_sec = ts.tv_sec; - tvnow.tv_usec = ts.tv_nsec / 1000; + tvnow.tv_usec = (int)(ts.tv_nsec / 1000); timeradd(tv, &tvnow, &tvsum); #else if (gettimeofday(&tvnow, NULL) < 0) diff --git a/src/common/crypto.c b/src/common/crypto.c index 72c1c45983..56409b47e2 100644 --- a/src/common/crypto.c +++ b/src/common/crypto.c @@ -67,6 +67,9 @@ ENABLE_GCC_WARNING(redundant-decls) #ifdef HAVE_SYS_SYSCALL_H #include <sys/syscall.h> #endif +#ifdef HAVE_SYS_RANDOM_H +#include <sys/random.h> +#endif #include "torlog.h" #include "torint.h" |