summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--changes/bug171506
-rw-r--r--src/or/routerlist.c4
2 files changed, 8 insertions, 2 deletions
diff --git a/changes/bug17150 b/changes/bug17150
new file mode 100644
index 0000000000..3fb78213d9
--- /dev/null
+++ b/changes/bug17150
@@ -0,0 +1,6 @@
+ o Minor bugfixes (directory warnings):
+ - When fetching extrainfo documents, compare their SHA256 digests
+ with the routerinfo that led us to fetch them, rather than
+ with the most recent routerinfo. Otherwise we generate many
+ spurious warnings about mismatches. Fixes bug 17150; bugfix
+ on 0.2.7.2-alpha.
diff --git a/src/or/routerlist.c b/src/or/routerlist.c
index 3d85d86f20..2e347b0692 100644
--- a/src/or/routerlist.c
+++ b/src/or/routerlist.c
@@ -4926,9 +4926,9 @@ routerinfo_incompatible_with_extrainfo(const routerinfo_t *ri,
/* Set digest256_matches to 1 if the digest is correct, or if no
* digest256 was in the ri. */
digest256_matches = tor_memeq(ei->digest256,
- ri->cache_info.extra_info_digest256, DIGEST256_LEN);
+ sd->extra_info_digest256, DIGEST256_LEN);
digest256_matches |=
- tor_mem_is_zero(ri->cache_info.extra_info_digest256, DIGEST256_LEN);
+ tor_mem_is_zero(sd->extra_info_digest256, DIGEST256_LEN);
/* The identity must match exactly to have been generated at the same time
* by the same router. */