summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--src/common/compat.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/src/common/compat.c b/src/common/compat.c
index 5f8f35d752..7f0823bbe1 100644
--- a/src/common/compat.c
+++ b/src/common/compat.c
@@ -291,6 +291,10 @@ set_socket_nonblocking(int socket)
* stack is down). And even if it succeeds, the socket pair will not
* be able to read while localhost is down later (the socket pair may
* even close, depending on OS-specific timeouts).
+ *
+ * XXX Bug: this function assumes errno is how you report errors, but
+ * that isn't the case for Windows, which is where it's most likely
+ * to be called.
**/
int
tor_socketpair(int family, int type, int protocol, int fd[2])