aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--changes/bug177813
-rw-r--r--src/or/connection_edge.c2
2 files changed, 4 insertions, 1 deletions
diff --git a/changes/bug17781 b/changes/bug17781
new file mode 100644
index 0000000000..01ed231b0a
--- /dev/null
+++ b/changes/bug17781
@@ -0,0 +1,3 @@
+ o Compilation fixes:
+ - Fix a compilation warning with Clang 3.6: Do not check the
+ presence of an address which can never be NULL. Fixes bug 17781.
diff --git a/src/or/connection_edge.c b/src/or/connection_edge.c
index 895c0f7f01..39f8af61f6 100644
--- a/src/or/connection_edge.c
+++ b/src/or/connection_edge.c
@@ -748,7 +748,7 @@ connection_ap_fail_onehop(const char *failed_digest,
/* we don't know the digest; have to compare addr:port */
tor_addr_t addr;
if (!build_state || !build_state->chosen_exit ||
- !entry_conn->socks_request || !entry_conn->socks_request->address)
+ !entry_conn->socks_request)
continue;
if (tor_addr_parse(&addr, entry_conn->socks_request->address)<0 ||
!tor_addr_eq(&build_state->chosen_exit->addr, &addr) ||