relay: Move log notice after suggested address lookup

When trying to find our address to publish, we would log notice if we couldn't
find it from the cache but then we would look at the suggested cache (which
contains the address from the authorities) in which we might actually have the
address.

Thus that log notice was misplaced. Move it down after the suggested address
cache lookup.

Closes #40300

Signed-off-by: David Goulet <dgoulet@torproject.org>

1 files changed, 13 insertions, 12 deletions

diff --git a/src/feature/relay/relay_find_addr.c b/src/feature/relay/relay_find_addr.c
index 39e1cc6a19..2a3f602438 100644
--- a/src/feature/relay/relay_find_addr.c
+++ b/src/feature/relay/relay_find_addr.c
@@ -144,17 +144,6 @@ relay_find_addr_to_publish, (const or_options_t *options, int family,
     if (find_my_address(options, family, LOG_INFO, addr_out, NULL, NULL)) {
       goto found;
     }
-    /* No publishable address was found even though we have an ORPort thus
-     * print a notice log so operator can notice. We'll do that every hour so
-     * it is not too spammy but enough so operators address the issue. */
-    static ratelim_t rlim = RATELIM_INIT(3600);
-    log_fn_ratelim(&rlim, LOG_NOTICE, LD_CONFIG,
-                   "Unable to find %s address for ORPort %u. "
-                   "You might want to specify %sOnly to it or set an "
-                   "explicit address or set Address.",
-                   fmt_af_family(family),
-                   routerconf_find_or_port(options, family),
-                   fmt_af_family(family));
   }
 
   /* Third, consider address from our suggestion cache. */
@@ -163,7 +152,19 @@ relay_find_addr_to_publish, (const or_options_t *options, int family,
     goto found;
   }
 
-  /* No publishable address was found. */
+  /* No publishable address was found even though we have an ORPort thus
+   * print a notice log so operator can notice. We'll do that every hour so
+   * it is not too spammy but enough so operators address the issue. */
+  static ratelim_t rlim = RATELIM_INIT(3600);
+  log_fn_ratelim(&rlim, LOG_NOTICE, LD_CONFIG,
+                 "Unable to find %s address for ORPort %u. "
+                 "You might want to specify %sOnly to it or set an "
+                 "explicit address or set Address.",
+                 fmt_af_family(family),
+                 routerconf_find_or_port(options, family),
+                 fmt_af_family(family));
+
+  /* Not found. */
   return false;
 
  found: