diff options
| author | Nick Mathewson <nickm@torproject.org> | 2016-11-30 07:51:40 -0500 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2016-12-16 11:06:20 -0500 |
| commit | 17c3faa2e393c59e9ee4aeca6986b0905d17f3b5 (patch) | |
| tree | fb120629e1514e51a620e700ed236a12f5973451 /src | |
| parent | 9d065ecc3d9e1a34c35be2d3531696798f6ecd3e (diff) | |
| download | tor-17c3faa2e393c59e9ee4aeca6986b0905d17f3b5.tar.gz tor-17c3faa2e393c59e9ee4aeca6986b0905d17f3b5.zip | |
guards_choose_dirguard(): replace one XXXX with another.
I had been asking myself, "hey, doesn't the new code need to look at
this "info" parameter? The old code did!" But it turns out that the
old code hasn't, since 05f7336624d6a47b3.
So instead of "support this!" the comment now says "we can remove
this!"
Diffstat (limited to 'src')
| -rw-r--r-- | src/or/entrynodes.c | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/src/or/entrynodes.c b/src/or/entrynodes.c index 9630f170f1..dd3a890a2b 100644 --- a/src/or/entrynodes.c +++ b/src/or/entrynodes.c @@ -4779,7 +4779,13 @@ guards_choose_dirguard(dirinfo_type_t info, if (get_options()->UseDeprecatedGuardAlgorithm) { return choose_random_dirguard(info); } else { - // XXXX prop271 look at info? + /* XXXX prop271 We don't need to look at the dirinfo_type_t here, + * apparently. If you look at the old implementation, and you follow info + * downwards through choose_random_dirguard(), into + * choose_random_entry_impl(), into populate_live_entry_guards()... you + * find out that it isn't even used, and hasn't been since 0.2.7.1-alpha, + * when we realized that every Tor on the network would support + * microdescriptors. -NM */ const node_t *r = NULL; if (entry_guard_pick_for_circuit(get_guard_selection_info(), &r, |