diff options
| author | Nick Mathewson <nickm@torproject.org> | 2007-02-01 18:33:02 +0000 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2007-02-01 18:33:02 +0000 |
| commit | 85076992560c80502b81424eb08d876e61e0f068 (patch) | |
| tree | 229ba8e7caad310f01c8b8d25a620f390276a3b0 /src | |
| parent | 6f2a92c5b3b9a9f4431018f78fed3ddafc328882 (diff) | |
| download | tor-85076992560c80502b81424eb08d876e61e0f068.tar.gz tor-85076992560c80502b81424eb08d876e61e0f068.zip | |
r11624@catbus: nickm | 2007-02-01 13:17:35 -0500
Note a few questionable bits pointed out by RATS. (And no, RATS, I'm not about to stop having fixed-sized local buffers for you. I know how to use them, thankyouverymuch.)
svn:r9474
Diffstat (limited to 'src')
| -rw-r--r-- | src/common/log.c | 2 | ||||
| -rw-r--r-- | src/or/eventdns.c | 1 | ||||
| -rw-r--r-- | src/or/main.c | 1 |
3 files changed, 4 insertions, 0 deletions
diff --git a/src/common/log.c b/src/common/log.c index 6e0366835c..27facbdbff 100644 --- a/src/common/log.c +++ b/src/common/log.c @@ -231,6 +231,8 @@ logv(int severity, uint32_t domain, const char *funcname, const char *format, } if (lf->is_syslog) { #ifdef HAVE_SYSLOG_H + /* XXXX Some syslog implementations have scary limits on the length of + * what you can pass them. Can/should we detect this? */ syslog(severity, "%s", end_of_prefix); #endif lf = lf->next; diff --git a/src/or/eventdns.c b/src/or/eventdns.c index 6bf195b4da..055dee54d6 100644 --- a/src/or/eventdns.c +++ b/src/or/eventdns.c @@ -2768,6 +2768,7 @@ load_nameservers_with_getnetworkparams(void) IP_ADDR_STRING *ns; GetNetworkParams_fn_t fn; + /* XXXX Possibly, we should hardcode the location of this DLL. */ if (!(handle = LoadLibrary("iphlpapi.dll"))) { log(EVDNS_LOG_WARN, "Could not open iphlpapi.dll"); //right now status = 0, doesn't that mean "good" - mikec diff --git a/src/or/main.c b/src/or/main.c index a54e2d82fc..7517770347 100644 --- a/src/or/main.c +++ b/src/or/main.c @@ -1775,6 +1775,7 @@ nt_service_loadlibrary(void) if (service_fns.loaded) return 0; + /* XXXX Possibly, we should hardcode the location of this DLL. */ if (!(library = LoadLibrary("advapi32.dll"))) { log_err(LD_GENERAL, "Couldn't open advapi32.dll. Are you trying to use " "NT services on Windows 98? That doesn't work."); |