aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorDavid Goulet <dgoulet@torproject.org>2023-09-18 09:10:39 -0400
committerDavid Goulet <dgoulet@torproject.org>2023-09-18 09:10:39 -0400
commitcd2bc94c44c5b01044105ab4bd844e84bf2b163e (patch)
treefc8d7352a545a8ed6a53624b330b3d1103fa86ef /src
parentc24203cf31328c21169d3af87265d110ccc86080 (diff)
parentd9a6b37ab1597ac726e5f972ebfbccf024c58cbc (diff)
downloadtor-cd2bc94c44c5b01044105ab4bd844e84bf2b163e.tar.gz
tor-cd2bc94c44c5b01044105ab4bd844e84bf2b163e.zip
Merge branch 'tor-gitlab/mr/761' into maint-0.4.8
Diffstat (limited to 'src')
-rw-r--r--src/lib/compress/compress.c10
-rw-r--r--src/test/test_util.c2
2 files changed, 10 insertions, 2 deletions
diff --git a/src/lib/compress/compress.c b/src/lib/compress/compress.c
index 83e63905cc..346e77f07d 100644
--- a/src/lib/compress/compress.c
+++ b/src/lib/compress/compress.c
@@ -66,7 +66,15 @@ tor_compress_is_compression_bomb,(size_t size_in, size_t size_out))
if (size_in == 0 || size_out < CHECK_FOR_COMPRESSION_BOMB_AFTER)
return 0;
- return (size_out / size_in > MAX_UNCOMPRESSION_FACTOR);
+ if (size_out / size_in > MAX_UNCOMPRESSION_FACTOR) {
+ log_warn(LD_GENERAL,
+ "Detected possible compression bomb with "
+ "input size = %"TOR_PRIuSZ " and output size = %"TOR_PRIuSZ,
+ size_in, size_out);
+ return 1;
+ }
+
+ return 0;
}
/** Guess the size that <b>in_len</b> will be after compression or
diff --git a/src/test/test_util.c b/src/test/test_util.c
index 1dae2c617e..391c3d07c1 100644
--- a/src/test/test_util.c
+++ b/src/test/test_util.c
@@ -2945,7 +2945,7 @@ test_util_gzip_compression_bomb(void *arg)
tt_int_op(-1, OP_EQ, tor_compress(&result, &result_len,
one_mb, one_million,
ZLIB_METHOD));
- expect_single_log_msg_containing(
+ expect_log_msg_containing(
"We compressed something and got an insanely high "
"compression factor; other Tors would think this "
"was a compression bomb.");