diff options
| author | Mike Perry <mikeperry-git@torproject.org> | 2019-06-05 12:33:39 -0700 |
|---|---|---|
| committer | George Kadianakis <desnacked@riseup.net> | 2019-07-23 12:22:25 +0300 |
| commit | a3089662c0e20bbddd17e6187f9fd3a00b1fe0c4 (patch) | |
| tree | 78738fb5c704354ec015af72f9de1c4eca0b48c3 /src | |
| parent | 86f298441b6df41c1d26614db2885bbcd48d8160 (diff) | |
| download | tor-a3089662c0e20bbddd17e6187f9fd3a00b1fe0c4.tar.gz tor-a3089662c0e20bbddd17e6187f9fd3a00b1fe0c4.zip | |
More LOG_PROTOCOL_WARN.
Make origin-side messages about padding negotiation failure into
LOG_PROTOCOL_WARN.
I'm not sure I like this either.. But the negotiation refusal case might
happen naturally due to consensus drift, and is functionally no different than
a corrupted cell.
Diffstat (limited to 'src')
| -rw-r--r-- | src/core/or/circuitpadding.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/core/or/circuitpadding.c b/src/core/or/circuitpadding.c index 63281d1368..8346ea4aed 100644 --- a/src/core/or/circuitpadding.c +++ b/src/core/or/circuitpadding.c @@ -2433,7 +2433,7 @@ circpad_handle_padding_negotiate(circuit_t *circ, cell_t *cell) circpad_negotiate_t *negotiate; if (CIRCUIT_IS_ORIGIN(circ)) { - log_fn(LOG_WARN, LD_CIRC, + log_fn(LOG_PROTOCOL_WARN, LD_CIRC, "Padding negotiate cell unsupported at origin."); return -1; } @@ -2498,7 +2498,7 @@ circpad_handle_padding_negotiated(circuit_t *circ, cell_t *cell, /* Verify this came from the expected hop */ if (!circpad_padding_is_from_expected_hop(circ, layer_hint)) { - log_fn(LOG_WARN, LD_CIRC, + log_fn(LOG_PROTOCOL_WARN, LD_CIRC, "Padding negotiated cell from wrong hop!"); return -1; } @@ -2524,7 +2524,7 @@ circpad_handle_padding_negotiated(circuit_t *circ, cell_t *cell, // and be sad free_circ_machineinfos_with_machine_num(circ, negotiated->machine_type); TO_ORIGIN_CIRCUIT(circ)->padding_negotiation_failed = 1; - log_fn(LOG_INFO, LD_CIRC, + log_fn(LOG_PROTOCOL_WARN, LD_CIRC, "Middle node did not accept our padding request."); } |