summaryrefslogtreecommitdiff
path: root/src/test
diff options
context:
space:
mode:
authorNick Mathewson <nickm@torproject.org>2014-09-29 09:18:03 -0400
committerNick Mathewson <nickm@torproject.org>2014-09-29 09:18:03 -0400
commit11ebbf5e88a55c15bdec0d16f0f60b24ee747fc9 (patch)
tree70baaebe2337e0b8f426117727357d56f00504bf /src/test
parent5e8cc766e6a4d297c66ff1afd6a5f8024607ef9c (diff)
parentfcebc8da95af5ccb28d715a6897566ea1c190a03 (diff)
downloadtor-11ebbf5e88a55c15bdec0d16f0f60b24ee747fc9.tar.gz
tor-11ebbf5e88a55c15bdec0d16f0f60b24ee747fc9.zip
Merge branch 'bug12971_take2_squashed'
Diffstat (limited to 'src/test')
-rw-r--r--src/test/test_socks.c18
1 files changed, 14 insertions, 4 deletions
diff --git a/src/test/test_socks.c b/src/test/test_socks.c
index 20f58ca92a..2b8f824b50 100644
--- a/src/test/test_socks.c
+++ b/src/test/test_socks.c
@@ -143,23 +143,33 @@ test_socks_5_unsupported_commands(void *ptr)
ADD_DATA(buf, "\x05\x02\x00\x01\x02\x02\x02\x01\x01\x01");
tt_int_op(fetch_from_buf_socks(buf, socks, get_options()->TestSocks,
get_options()->SafeSocks),==, -1);
- /* XXX: shouldn't tor reply 'command not supported' [07]? */
+
+ tt_int_op(5,==,socks->socks_version);
+ tt_int_op(10,==,socks->replylen);
+ tt_int_op(5,==,socks->reply[0]);
+ tt_int_op(SOCKS5_COMMAND_NOT_SUPPORTED,==,socks->reply[1]);
+ tt_int_op(1,==,socks->reply[3]);
buf_clear(buf);
socks_request_clear(socks);
/* SOCKS 5 Send unsupported UDP_ASSOCIATE [03] command */
- ADD_DATA(buf, "\x05\x03\x00\x01\x02");
+ ADD_DATA(buf, "\x05\x02\x00\x01");
tt_int_op(fetch_from_buf_socks(buf, socks, get_options()->TestSocks,
get_options()->SafeSocks),==, 0);
tt_int_op(5,==, socks->socks_version);
tt_int_op(2,==, socks->replylen);
tt_int_op(5,==, socks->reply[0]);
- tt_int_op(2,==, socks->reply[1]);
+ tt_int_op(0,==, socks->reply[1]);
ADD_DATA(buf, "\x05\x03\x00\x01\x02\x02\x02\x01\x01\x01");
tt_int_op(fetch_from_buf_socks(buf, socks, get_options()->TestSocks,
get_options()->SafeSocks),==, -1);
- /* XXX: shouldn't tor reply 'command not supported' [07]? */
+
+ tt_int_op(5,==,socks->socks_version);
+ tt_int_op(10,==,socks->replylen);
+ tt_int_op(5,==,socks->reply[0]);
+ tt_int_op(SOCKS5_COMMAND_NOT_SUPPORTED,==,socks->reply[1]);
+ tt_int_op(1,==,socks->reply[3]);
done:
;