summaryrefslogtreecommitdiff
path: root/src/test
diff options
context:
space:
mode:
authorNick Mathewson <nickm@torproject.org>2012-10-23 21:51:38 -0400
committerNick Mathewson <nickm@torproject.org>2012-10-23 21:51:38 -0400
commit04a509e04b0e22530e6a1a81c1a0884ad7010eb0 (patch)
tree5fd7600395c814463d5ebe491d29ef0f7a7198d0 /src/test
parent9064238495151915699fa50c437722f236b877fc (diff)
parent500ebdb2f3a7eb357f755d6cae28ff2bc750efec (diff)
downloadtor-04a509e04b0e22530e6a1a81c1a0884ad7010eb0.tar.gz
tor-04a509e04b0e22530e6a1a81c1a0884ad7010eb0.zip
Merge remote-tracking branch 'andrea/bug7191_v2'
Diffstat (limited to 'src/test')
-rw-r--r--src/test/test_containers.c36
1 files changed, 36 insertions, 0 deletions
diff --git a/src/test/test_containers.c b/src/test/test_containers.c
index 10146c5f64..399ef8e90f 100644
--- a/src/test/test_containers.c
+++ b/src/test/test_containers.c
@@ -16,6 +16,15 @@ compare_strs_(const void **a, const void **b)
return strcmp(s1, s2);
}
+/** Helper: return a tristate based on comparing the strings in <b>a</b> and
+ * *<b>b</b>. */
+static int
+compare_strs_for_bsearch_(const void *a, const void **b)
+{
+ const char *s1 = a, *s2 = *b;
+ return strcmp(s1, s2);
+}
+
/** Helper: return a tristate based on comparing the strings in *<b>a</b> and
* *<b>b</b>, excluding a's first character, and ignoring case. */
static int
@@ -204,6 +213,8 @@ test_container_smartlist_strings(void)
/* Test bsearch_idx */
{
int f;
+ smartlist_t *tmp = NULL;
+
test_eq(0, smartlist_bsearch_idx(sl," aaa",compare_without_first_ch_,&f));
test_eq(f, 0);
test_eq(0, smartlist_bsearch_idx(sl," and",compare_without_first_ch_,&f));
@@ -216,6 +227,31 @@ test_container_smartlist_strings(void)
test_eq(f, 0);
test_eq(7, smartlist_bsearch_idx(sl," zzzz",compare_without_first_ch_,&f));
test_eq(f, 0);
+
+ /* Test trivial cases for list of length 0 or 1 */
+ tmp = smartlist_new();
+ test_eq(0, smartlist_bsearch_idx(tmp, "foo",
+ compare_strs_for_bsearch_, &f));
+ test_eq(f, 0);
+ smartlist_insert(tmp, 0, (void *)("bar"));
+ test_eq(1, smartlist_bsearch_idx(tmp, "foo",
+ compare_strs_for_bsearch_, &f));
+ test_eq(f, 0);
+ test_eq(0, smartlist_bsearch_idx(tmp, "aaa",
+ compare_strs_for_bsearch_, &f));
+ test_eq(f, 0);
+ test_eq(0, smartlist_bsearch_idx(tmp, "bar",
+ compare_strs_for_bsearch_, &f));
+ test_eq(f, 1);
+ /* ... and one for length 2 */
+ smartlist_insert(tmp, 1, (void *)("foo"));
+ test_eq(1, smartlist_bsearch_idx(tmp, "foo",
+ compare_strs_for_bsearch_, &f));
+ test_eq(f, 1);
+ test_eq(2, smartlist_bsearch_idx(tmp, "goo",
+ compare_strs_for_bsearch_, &f));
+ test_eq(f, 0);
+ smartlist_free(tmp);
}
/* Test reverse() and pop_last() */