diff options
| author | Nick Mathewson <nickm@torproject.org> | 2016-06-02 09:46:12 -0400 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2016-06-11 10:11:54 -0400 |
| commit | 53a3b39da1241ba43f63f1515f6ef5167b182cae (patch) | |
| tree | 558ec394f3a02bb8f2b5e887ff70b82231424143 /src/test/test_policy.c | |
| parent | 80f1a2cbbdd0abd509711a5069f31855df5bcd79 (diff) | |
| download | tor-53a3b39da1241ba43f63f1515f6ef5167b182cae.tar.gz tor-53a3b39da1241ba43f63f1515f6ef5167b182cae.zip | |
Add -Wmissing-variable-declarations, with attendant fixes
This is a big-ish patch, but it's very straightforward. Under this
clang warning, we're not actually allowed to have a global variable
without a previous extern declaration for it. The cases where we
violated this rule fall into three roughly equal groups:
* Stuff that should have been static.
* Stuff that was global but where the extern was local to some
other C file.
* Stuff that was only global when built for the unit tests, that
needed a conditional extern in the headers.
The first two were IMO genuine problems; the last is a wart of how
we build tests.
Diffstat (limited to 'src/test/test_policy.c')
| -rw-r--r-- | src/test/test_policy.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/test/test_policy.c b/src/test/test_policy.c index a939ebf54f..913a2f303a 100644 --- a/src/test/test_policy.c +++ b/src/test/test_policy.c @@ -778,8 +778,8 @@ test_policies_reject_port_address(void *arg) UNMOCK(get_configured_ports); } -smartlist_t *mock_ipv4_addrs = NULL; -smartlist_t *mock_ipv6_addrs = NULL; +static smartlist_t *mock_ipv4_addrs = NULL; +static smartlist_t *mock_ipv6_addrs = NULL; /* mock get_interface_address6_list, returning a deep copy of the template * address list ipv4_interface_address_list or ipv6_interface_address_list */ |