Base tests for 11243: test parsing for md, ei, and ri.

We didn't really have test coverage for these parsing functions, so
I went and made some.  These tests also verify that the parsing
functions set the list of invalid digests correctly.

1 files changed, 228 insertions, 0 deletions

diff --git a/src/test/test_microdesc.c b/src/test/test_microdesc.c
index f7e87ac6e4..907303418b 100644
--- a/src/test/test_microdesc.c
+++ b/src/test/test_microdesc.c
@@ -12,6 +12,10 @@
 
 #include "test.h"
 
+#include <openssl/rsa.h>
+#include <openssl/bn.h>
+#include <openssl/pem.h>
+
 #ifdef _WIN32
 /* For mkdir() */
 #include <direct.h>
@@ -391,10 +395,234 @@ test_md_generate(void *arg)
   routerinfo_free(ri);
 }
 
+/* Taken at random from my ~/.tor/cached-microdescs file and then
+ * hand-munged */
+static const char MD_PARSE_TEST_DATA[] =
+  /* Good 0 */
+  "onion-key\n"
+  "-----BEGIN RSA PUBLIC KEY-----\n"
+  "MIGJAoGBANsKd1GRfOuSR1MkcwKqs6SVy4Gi/JXplt/bHDkIGm6Q96TeJ5uyVgUL\n"
+  "DBr/ij6+JqgVFeriuiMzHKREytzjdaTuKsKBFFpLwb+Ppcjr5nMIH/AR6/aHO8hW\n"
+  "T3B9lx5T6Kl7CqZ4yqXxYRHzn50EPTIZuz0y9se4J4gi9mLmL+pHAgMBAAE=\n"
+  "-----END RSA PUBLIC KEY-----\n"
+  "p accept 20-23,43,53,79-81,88,110,143,194,220,443,464,531,543-544\n"
+  "id rsa1024 GEo59/iR1GWSIWZDzXTd5QxtqnU\n"
+  /* Bad 0: I've messed with the onion-key in the second one. */
+  "onion-key\n"
+  "-----BEGIN RSA PUBLIC KEY-----\n"
+  "MIGJAoGBAMr4o/pflVwscx11vC1AKEADlKEqnhpvCIjAEzNEenMhvGQHRlA0EXLC\n"
+  "7G7O5bhnCwEHqK8Pvg8cuX/fD8v08TF1EVPhwPa0UI6ab8KnPP2F!!!!!!b92DG7EQIk3q\n"
+  "d68Uxp7E9/t3v1WWZjzDqvEe0par6ul+DKW6HMlTGebFo5Q4e8R1AgMBAAE=\n"
+  "-----END RSA PUBLIC KEY-----\n"
+  "ntor-onion-key 761Dmm27via7lXygNHM3l+oJLrYU2Nye0Uz4pkpipyY=\n"
+  "p accept 53\n"
+  "id rsa1024 3Y4fwXhtgkdGDZ5ef5mtb6TJRQQ\n"
+  /* Good 1 */
+  "onion-key\n"
+  "-----BEGIN RSA PUBLIC KEY-----\n"
+  "MIGJAoGBANsMSjVi3EX8ZHfm/dvPF6KdVR66k1tVul7Jp+dDbDajBYNhgKRzVCxy\n"
+  "Yac1CBuQjOqK89tKap9PQBnhF087eDrfaZDqYTLwB2W2sBJncVej15WEPXPRBifo\n"
+  "iFZ8337kgczkaY+IOfSuhtbOUyDOoDpRJheIKBNq0ZiTqtLbbadVAgMBAAE=\n"
+  "-----END RSA PUBLIC KEY-----\n"
+  "ntor-onion-key ncfiHJjSgdDEW/gc6q6/7idac7j+x7ejQrRm6i75pGA=\n"
+  "p accept 443,6660-6669,6697,7000-7001\n"
+  "id rsa1024 XXuLzw3mfBELEq3veXoNhdehwD4\n"
+  /* Good 2 */
+  "onion-key\n"
+  "-----BEGIN RSA PUBLIC KEY-----\n"
+  "MIGJAoGBANQfBlrHrh9F/CAOytrNFgi0ikWMW/HZxuoszF9X+AQ+MudR8bcxxOGl\n"
+  "1RFwb74s8E3uuzrCkNFvSw9Ar1L02F2DOX0gLsxEGuYC4Ave9NUteGqSqDyEJQUJ\n"
+  "KlfxCPn2qC9nvNT7wR/Dg2WRvAEKnJmkpb57N3+WSAOPLjKOFEz3AgMBAAE=\n"
+  "-----END RSA PUBLIC KEY-----\n"
+  "ntor-onion-key AppBt6CSeb1kKid/36ototmFA24ddfW5JpjWPLuoJgs=\n"
+  "id rsa1024 6y60AEI9a1PUUlRPO0YQT9WzrjI\n"
+  /* Bad 1: Here I've messed with the ntor key */
+  "onion-key\n"
+  "-----BEGIN RSA PUBLIC KEY-----\n"
+  "MIGJAoGBAPjy2HacU3jDNO5nTOFGSwNa0qKCNn4yhtrDVcAJ5alIQeBWZZGJLZ0q\n"
+  "Cqylw1vYqxu8E09g+QXXFbAgBv1U9TICaATxrIJhIJzc8TJPhqJemp1kq0DvHLDx\n"
+  "mxwlkNnCD/P5NS+JYB3EjOlU9EnSKUWNU61+Co344m2JqhEau40vAgMBAAE=\n"
+  "-----END RSA PUBLIC KEY-----\n"
+  "ntor-onion-key 4i2Fp9JHTUr1uQs0pxD5j5spl4/RG56S2P0gQxU=\n"
+  "id rsa1024 nMRmNEGysA0NmlALVaUmI7D5jLU\n"
+  /* Good 3: I've added a weird token in this one. This shouldn't prevent
+   * it parsing */
+  "onion-key\n"
+  "-----BEGIN RSA PUBLIC KEY-----\n"
+  "MIGJAoGBAKmosxudyNA/yJNz3S890VqV/ebylzoD11Sc0b/d5tyNNaNZjcYy5vRD\n"
+  "kwyxFRMbP2TLZQ1zRfNwY7IDnYjU2SbW0pxuM6M8WRtsmx/YOE3kHMVAFJNrTUqU\n"
+  "6D1zB3IiRDS5q5+NoRxwqo+hYUck60O3WTwEoqb+l3lvXeu7z9rFAgMBAAE=\n"
+  "-----END RSA PUBLIC KEY-----\n"
+  "flux-capacitor 1.21 GW\n"
+  "ntor-onion-key MWBoEkl+RlBiGX44XKIvTSqbznTNZStOmUYtcYRQQyY=\n"
+  "id rsa1024 R+A5O9qRvRac4FT3C4L2QnFyxsc\n"
+  /* Good 4: Here I've made the 'id rsa' token odd.  It should still parse
+   * just fine. */
+  "onion-key\n"
+  "-----BEGIN RSA PUBLIC KEY-----\n"
+  "MIGJAoGBAOh+WMkdNe/Pkjb8UjQyfLOlFgpuVFrxAIGnJsmWWx0yBE97DQxGyh2n\n"
+  "h8G5OJZHRarJQyCIf7vpZQAi0oP0OkGGaCaDQsM+D8TnqhnU++RWGnMqY/cXxPrL\n"
+  "MEq+n6aGiLmzkO7ah8yorZpoREk4GqLUIN89/tHHGOhJL3c4CPGjAgMBAAE=\n"
+  "-----END RSA PUBLIC KEY-----\n"
+  "p reject 25,119,135-139,445,563,1214,4661-4666,6346-6429,6699,6881-6999\n"
+  "id rsa1234 jlqAKFD2E7uMKv+8TmKSeo7NBho\n"
+  /* Good 5: Extra id type. */
+  "onion-key\n"
+  "-----BEGIN RSA PUBLIC KEY-----\n"
+  "MIGJAoGBAMdgPPc5uaw4y/q+SUTN/I8Y+Gvdx9kKgWV4dmDGJ0mxsVZmo1v6+v3F\n"
+  "12M2f9m99G3WB8F8now29C+9XyEv8MBHj1lHRdUFHSQes3YTFvDNlgj+FjLqO5TJ\n"
+  "adOOmfu4DCUUtUEDyQKbNVL4EkMTXY73omTVsjcH3xxFjTx5wixhAgMBAAE=\n"
+  "-----END RSA PUBLIC KEY-----\n"
+  "ntor-onion-key AAVnWZcnDbxasdZwKqb4fL6O9sZV+XsRNHTpNd1YMz8=\n"
+  "id rsa1024 72EfBL11QuwX2vU8y+p9ExGfGEg\n"
+  "id expolding hedgehog 0+A5O9qRvRac4FT3C4L2QnFyxsc\n"
+  /* Good 6: I've given this a bogus policy. It should parse. */
+  "onion-key\n"
+  "-----BEGIN RSA PUBLIC KEY-----\n"
+  "MIGJAoGBALNuufwhPMF8BooxYMNvhYJMPqUB8hQDt8wGmPKphJcD1sVD1i4gAZM2\n"
+  "HIo+zUBlljDrRWL5NzVzd1yxUJAiQxvXS5dRRFY3B70M7wTVpXw53xe0/BM5t1AX\n"
+  "n0MFk7Jl6XIKMlzRalZvmMvE/odtyWXkP4Nd1MyZ1QcIwrQ2iwyrAgMBAAE=\n"
+  "-----END RSA PUBLIC KEY-----\n"
+  "p condone 1-10\n"
+  "ntor-onion-key 2/nMJ+L4dd/2GpMyTYjz3zC59MvQy4MIzJZhdzKHekg=\n"
+  "id rsa1024 FHyh10glEMA6MCmBb5R9Y+X/MhQ\n"
+  /* Good 7: I've given this one another sort of odd policy. Should parse. */
+  "onion-key\n"
+  "-----BEGIN RSA PUBLIC KEY-----\n"
+  "MIGJAoGBAKcd3FmQ8iAADghyvX8eca0ePqtJ2w1IDdUdTlf5Y/8+OMdp//sD01yC\n"
+  "YmiX45LK5ge1O3AzcakYCO6fb3pyIqvXdvm24OjyYZELQ40cmKSLjdhcSf4Fr/N9\n"
+  "uR/CkknR9cEePu1wZ5WBIGmGdXI6s7t3LB+e7XFyBYAx6wMGlnX7AgMBAAE=\n"
+  "-----END RSA PUBLIC KEY-----\n"
+  "p accept frogs-mice\n"
+  "ntor-onion-key AMxvhaQ1Qg7jBJFoyHuPRgETvLbFmJ194hExV24FuAI=\n"
+  "family $D8CFEA0D996F5D1473D2063C041B7910DB23981E\n"
+  "id rsa1024 d0VVZC/cHh1P3y4MMbfKlQHFycc\n"
+  /* Good 8: This one has the ntor-onion-key without terminating =. That's
+   * allowed. */
+  "onion-key\n"
+  "-----BEGIN RSA PUBLIC KEY-----\n"
+  "MIGJAoGBAL438YfjrJE2SPqkkXeQwICygu8KNO54Juj6sjqk5hgsiazIWMOBgbaX\n"
+  "LIRqPNGaiSq01xSqwjwCBCfwZYT/nSdDBqj1h9aoR8rnjxZjyQ+m3rWpdDqeCDMx\n"
+  "I3NgZ5w4bNX4poRb42lrV6NmQiFdjzpqszVbv5Lpn2CSKu32CwKVAgMBAAE=\n"
+  "-----END RSA PUBLIC KEY-----\n"
+  "ntor-onion-key UKL6Dnj2KwYsFlkCvOkXVatxvOPB4MaxqwPQQgZMTwI\n"
+  "id rsa1024 FPIXc6k++JnKCtSKWUxaR6oXEKs\n"
+  /* Good 9: Another totally normal one.*/
+  "onion-key\n"
+  "-----BEGIN RSA PUBLIC KEY-----\n"
+  "MIGJAoGBANNGIKRd8PFNXkJ2JPV1ohDMFNbJwKbwybeieaQFjtU9KWedHCbr+QD4\n"
+  "B6zNY5ysguNjHNnlq2f6D09+uhnfDBON8tAz0mPQH/6JqnOXm+EiUn+8bN0E8Nke\n"
+  "/i3GEgDeaxJJMNQcpsJvmmSmKFOlYy9Fy7ejAjTGqtAnqOte7BnTAgMBAAE=\n"
+  "-----END RSA PUBLIC KEY-----\n"
+  "ntor-onion-key gUsq3e5iYgsQQvyxINtLzBpHxmIt5rtuFlEbKfI4gFk=\n"
+  "id rsa1024 jv+LdatDzsMfEW6pLBeL/5uzwCc\n"
+  /* Bad 2: RSA key has bad exponent of 3. */
+  "onion-key\n"
+  "-----BEGIN RSA PUBLIC KEY-----\n"
+  "MIGHAoGBAMMTWtvPxYnUNJ5Y7B+XENcpxzPoGstrdiUszCBS+/42xvluLJ+JDSdR\n"
+  "qJaMD6ax8vKAeLS5C6O17MNdG2VldlPRbtgl41MXsOoUqEJ+nY9e3WG9Snjp47xC\n"
+  "zmWIfeduXSavIsb3a43/MLIz/9qO0TkgAAiuQr79JlwKhLdzCqTLAgED\n"
+  "-----END RSA PUBLIC KEY-----\n"
+  "ntor-onion-key NkRB4wTUFogiVp5jYmjGORe2ffb/y5Kk8Itw8jdzMjA=\n"
+  "p reject 25,119,135-139,445,563,1214,4661-4666,6346-6429,6699,6881-6999\n"
+  "id rsa1024 fKvYjP7TAjCC1FzYee5bYAwYkoDg\n"
+  /* Bad 3: Bogus annotation */
+  "@last-listed with strange aeons\n"
+  "onion-key\n"
+  "-----BEGIN RSA PUBLIC KEY-----\n"
+  "MIGJAoGBALcRBFNCZtpd2TFJysU77/fJMFzKisRQEBOtDGtTZ2Bg4aEGosssa0Id\n"
+  "YtUagRLYle08QVGvGB+EHBI5qf6Ah2yPH7k5QiN2a3Sq+nyh85dXKPazBGBBbM+C\n"
+  "DOfDauV02CAnADNMLJEf1voY3oBVvYyIsmHxn5i1R19ZYIiR8NX5AgMBAAE=\n"
+  "-----END RSA PUBLIC KEY-----\n"
+  "ntor-onion-key m4xcFXMWMjCvZDXq8FT3XmS0EHYseGOeu+fV+6FYDlk=\n"
+  "p accept 20-23,43,53,79-81,88,110,143,194,220,389,443,464,531,543-544\n"
+  "id rsa1024 SSbfNE9vmaiwRKH+eqNAkiKQhds\n"
+  /* Good 10: Normal, with added ipv6 address and added other address */
+  "onion-key\n"
+  "-----BEGIN RSA PUBLIC KEY-----\n"
+  "MIGJAoGBAM7uUtq5F6h63QNYIvC+4NcWaD0DjtnrOORZMkdpJhinXUOwce3cD5Dj\n"
+  "sgdN1wJpWpTQMXJ2DssfSgmOVXETP7qJuZyRprxalQhaEATMDNJA/66Ml1jSO9mZ\n"
+  "+8Xb7m/4q778lNtkSbsvMaYD2Dq6k2QQ3kMhr9z8oUtX0XA23+pfAgMBAAE=\n"
+  "-----END RSA PUBLIC KEY-----\n"
+  "a [::1:2:3:4]:9090\n"
+  "a 18.0.0.1:9999\n"
+  "ntor-onion-key k2yFqTU2vzMCQDEiE/j9UcEHxKrXMLpB3IL0or09sik=\n"
+  "id rsa1024 2A8wYpHxnkKJ92orocvIQBzeHlE\n"
+  "p6 allow 80\n"
+  ;
+
+/** More tests for parsing different kinds of microdescriptors, and getting
+ * invalid digests trackd from them. */
+static void
+test_md_parse(void *arg)
+{
+  (void) arg;
+  char *mem_op_hex_tmp = NULL;
+  smartlist_t *invalid = smartlist_new();
+
+  smartlist_t *mds = microdescs_parse_from_string(MD_PARSE_TEST_DATA,
+                                                  NULL, 1, SAVED_NOWHERE,
+                                                  invalid);
+  tt_int_op(smartlist_len(mds), ==, 11);
+  tt_int_op(smartlist_len(invalid), ==, 4);
+
+  test_memeq_hex(smartlist_get(invalid,0),
+                 "5d76bf1c6614e885614a1e0ad074e1ab"
+                 "4ea14655ebeefb1736a71b5ed8a15a51");
+  test_memeq_hex(smartlist_get(invalid,1),
+                 "2fde0ee3343669c2444cd9d53cbd39c6"
+                 "a7d1fc0513513e840ca7f6e68864b36c");
+  test_memeq_hex(smartlist_get(invalid,2),
+                 "20d1576c5ab11bbcff0dedb1db4a3cfc"
+                 "c8bc8dd839d8cbfef92d00a1a7d7b294");
+  test_memeq_hex(smartlist_get(invalid,3),
+                 "074770f394c73dbde7b44412e9692add"
+                 "691a478d4727f9804b77646c95420a96");
+
+  /* Spot-check the valid ones. */
+  const microdesc_t *md = smartlist_get(mds, 5);
+  test_memeq_hex(md->digest,
+                 "54bb6d733ddeb375d2456c79ae103961"
+                 "da0cae29620375ac4cf13d54da4d92b3");
+  tt_int_op(md->last_listed, ==, 0);
+  tt_int_op(md->saved_location, ==, SAVED_NOWHERE);
+  tt_int_op(md->no_save, ==, 0);
+  tt_uint_op(md->held_in_map, ==, 0);
+  tt_uint_op(md->held_by_nodes, ==, 0);
+  tt_assert(md->onion_curve25519_pkey);
+
+  md = smartlist_get(mds, 6);
+  test_memeq_hex(md->digest,
+                 "53f740bd222ab37f19f604b1d3759aa6"
+                 "5eff1fbce9ac254bd0fa50d4af9b1bae");
+  tt_assert(! md->exit_policy);
+
+  md = smartlist_get(mds, 8);
+  test_memeq_hex(md->digest,
+                 "a0a155562d8093d8fd0feb7b93b7226e"
+                 "17f056c2142aab7a4ea8c5867a0376d5");
+  tt_assert(md->onion_curve25519_pkey);
+
+  md = smartlist_get(mds, 10);
+  test_memeq_hex(md->digest,
+                 "409ebd87d23925a2732bd467a92813c9"
+                 "21ca378fcb9ca193d354c51550b6d5e9");
+  tt_assert(tor_addr_family(&md->ipv6_addr) == AF_INET6);
+  tt_int_op(md->ipv6_orport, ==, 9090);
+
+ done:
+  SMARTLIST_FOREACH(mds, microdesc_t *, md, microdesc_free(md));
+  smartlist_free(mds);
+  SMARTLIST_FOREACH(invalid, char *, cp, tor_free(cp));
+  smartlist_free(invalid);
+  tor_free(mem_op_hex_tmp);
+}
+
 struct testcase_t microdesc_tests[] = {
   { "cache", test_md_cache, TT_FORK, NULL, NULL },
   { "broken_cache", test_md_cache_broken, TT_FORK, NULL, NULL },
   { "generate", test_md_generate, 0, NULL, NULL },
+  { "parse", test_md_parse, 0, NULL, NULL },
   END_OF_TESTCASES
 };