summaryrefslogtreecommitdiff
path: root/src/test/test_connection.c
diff options
context:
space:
mode:
authorDavid Goulet <dgoulet@torproject.org>2022-05-16 08:45:15 -0400
committerDavid Goulet <dgoulet@torproject.org>2022-05-16 08:45:15 -0400
commit0f7a1f0351ca88c925641a158cb1c1ea1cc218dc (patch)
tree5aa8d6bd6da075c884ca6de316392b9ca8ca06f3 /src/test/test_connection.c
parent2a4663fee839b454b971e6cc9a3c24528a74b5ff (diff)
parent15e95c3bda1e3781a7f7175de4e65a749e9d6a2c (diff)
downloadtor-0f7a1f0351ca88c925641a158cb1c1ea1cc218dc.tar.gz
tor-0f7a1f0351ca88c925641a158cb1c1ea1cc218dc.zip
Merge branch 'tor-gitlab/mr/561'
Diffstat (limited to 'src/test/test_connection.c')
-rw-r--r--src/test/test_connection.c21
1 files changed, 5 insertions, 16 deletions
diff --git a/src/test/test_connection.c b/src/test/test_connection.c
index fbf9d6a5ab..ed94fe8aaa 100644
--- a/src/test/test_connection.c
+++ b/src/test/test_connection.c
@@ -22,6 +22,7 @@
#include "feature/dircommon/directory.h"
#include "core/or/connection_or.h"
#include "lib/net/resolve.h"
+#include "lib/evloop/compat_libevent.h"
#include "test/test_connection.h"
#include "test/test_helpers.h"
@@ -113,14 +114,8 @@ test_conn_get_basic_teardown(const struct testcase_t *tc, void *arg)
/* We didn't call tor_libevent_initialize(), so event_base was NULL,
* so we can't rely on connection_unregister_events() use of event_del().
*/
- if (conn->linked_conn->read_event) {
- tor_free(conn->linked_conn->read_event);
- conn->linked_conn->read_event = NULL;
- }
- if (conn->linked_conn->write_event) {
- tor_free(conn->linked_conn->write_event);
- conn->linked_conn->write_event = NULL;
- }
+ tor_event_free(conn->linked_conn->read_event);
+ tor_event_free(conn->linked_conn->write_event);
if (!conn->linked_conn->marked_for_close) {
connection_close_immediate(conn->linked_conn);
@@ -142,14 +137,8 @@ test_conn_get_basic_teardown(const struct testcase_t *tc, void *arg)
/* We didn't set the events up properly, so we can't use event_del() in
* close_closeable_connections() > connection_free()
* > connection_unregister_events() */
- if (conn->read_event) {
- tor_free(conn->read_event);
- conn->read_event = NULL;
- }
- if (conn->write_event) {
- tor_free(conn->write_event);
- conn->write_event = NULL;
- }
+ tor_event_free(conn->read_event);
+ tor_event_free(conn->write_event);
if (!conn->marked_for_close) {
connection_close_immediate(conn);