diff options
author | Nick Mathewson <nickm@torproject.org> | 2014-02-11 18:10:33 -0500 |
---|---|---|
committer | Nick Mathewson <nickm@torproject.org> | 2014-02-11 18:10:33 -0500 |
commit | c3720c05fa44b3790ab0dc37e2506ee482796e21 (patch) | |
tree | 53e3146e10dbb647d13c3c64fcbe6549ff372ef0 /src/test/test_config.c | |
parent | 10d4d3e2d58f94418ca9554aee251232bbaaab99 (diff) | |
download | tor-c3720c05fa44b3790ab0dc37e2506ee482796e21.tar.gz tor-c3720c05fa44b3790ab0dc37e2506ee482796e21.zip |
Free leakable values in the unit tests.
Thanks, Coverity! (CID 1171414, 1171415, 1171416)
Diffstat (limited to 'src/test/test_config.c')
-rw-r--r-- | src/test/test_config.c | 11 |
1 files changed, 9 insertions, 2 deletions
diff --git a/src/test/test_config.c b/src/test/test_config.c index 3a1b6d7d88..a1dff644a0 100644 --- a/src/test/test_config.c +++ b/src/test/test_config.c @@ -247,6 +247,7 @@ test_config_write_to_data_subdir(void *arg) { or_options_t* options = get_options_mutable(); char *datadir = options->DataDirectory = tor_strdup(get_fname("datadir-1")); + char *cp = NULL; const char* subdir = "test_stats"; const char* fname = "test_file"; const char* str = @@ -280,17 +281,23 @@ test_config_write_to_data_subdir(void *arg) // Content of file after write attempt should be // equal to the original string. test_assert(!write_to_data_subdir(subdir, fname, str, NULL)); - test_streq(read_file_to_str(filepath, 0, NULL), str); + cp = read_file_to_str(filepath, 0, NULL); + test_streq(cp, str); + tor_free(cp); // A second write operation should overwrite the old content. test_assert(!write_to_data_subdir(subdir, fname, str, NULL)); - test_streq(read_file_to_str(filepath, 0, NULL), str); + cp = read_file_to_str(filepath, 0, NULL); + test_streq(cp, str); + tor_free(cp); + done: (void) unlink(filepath); rmdir(options->DataDirectory); tor_free(datadir); tor_free(filepath); + tor_free(cp); } /* Test helper function: Make sure that a bridge line gets parsed |