summaryrefslogtreecommitdiff
path: root/src/rust/protover
diff options
context:
space:
mode:
authorChelsea Holland Komlo <me@chelseakomlo.com>2017-10-26 09:50:50 -0400
committerNick Mathewson <nickm@torproject.org>2017-10-27 10:02:08 -0400
commit6be75bd61d72636a1c23b6fd9866d33a35433a73 (patch)
treee126a94f3baf863f49f5ff0addcc952ce20e3018 /src/rust/protover
parent90daad999e78c8ec8239e63ea03df6b3b2e364b6 (diff)
downloadtor-6be75bd61d72636a1c23b6fd9866d33a35433a73.tar.gz
tor-6be75bd61d72636a1c23b6fd9866d33a35433a73.zip
cargo fmt; fix line length warnings
Diffstat (limited to 'src/rust/protover')
-rw-r--r--src/rust/protover/ffi.rs1
-rw-r--r--src/rust/protover/protover.rs14
-rw-r--r--src/rust/protover/tests/protover.rs16
3 files changed, 16 insertions, 15 deletions
diff --git a/src/rust/protover/ffi.rs b/src/rust/protover/ffi.rs
index 23a289bd56..f897c98083 100644
--- a/src/rust/protover/ffi.rs
+++ b/src/rust/protover/ffi.rs
@@ -13,7 +13,6 @@ use tor_allocate::allocate_and_copy_string;
/// Translate C enums to Rust Proto enums, using the integer value of the C
/// enum to map to its associated Rust enum
/// This is dependant on the associated C enum preserving ordering.
-/// Modify the C documentation to give warnings- you must also re-order the rust
fn translate_to_rust(c_proto: uint32_t) -> Result<Proto, &'static str> {
match c_proto {
0 => Ok(Proto::Link),
diff --git a/src/rust/protover/protover.rs b/src/rust/protover/protover.rs
index 8a546e09a3..d75da61aa8 100644
--- a/src/rust/protover/protover.rs
+++ b/src/rust/protover/protover.rs
@@ -142,7 +142,8 @@ fn tor_supported() -> Result<HashMap<Proto, HashSet<u32>>, &'static str> {
/// This function will error if:
///
/// * the `version_string` is empty or contains an equals (`"="`) sign,
-/// * the expansion of a version range produces an error (see `expand_version_range`),
+/// * the expansion of a version range produces an error (see
+/// `expand_version_range`),
/// * any single version number is not parseable as an `u32` in radix 10, or
/// * there are greater than 2^16 version numbers to expand.
///
@@ -293,10 +294,12 @@ pub fn all_supported(protocols: &str) -> (bool, String) {
/// ```
/// use protover::*;
///
-/// let is_supported = protover_string_supports_protocol("Link=3-4 Cons=1", Proto::Cons,1);
+/// let is_supported = protover_string_supports_protocol("Link=3-4 Cons=1",
+/// Proto::Cons,1);
/// assert_eq!(true, is_supported);
///
-/// let is_not_supported = protover_string_supports_protocol("Link=3-4 Cons=1", Proto::Cons,5);
+/// let is_not_supported = protover_string_supports_protocol("Link=3-4 Cons=1",
+/// Proto::Cons,5);
/// assert_eq!(false, is_not_supported)
/// ```
pub fn protover_string_supports_protocol(
@@ -363,7 +366,7 @@ fn expand_version_range(range: &str) -> Result<Vec<u32>, &'static str> {
))?;
// We can use inclusive range syntax when it becomes stable.
- Ok((lower..higher+1).collect())
+ Ok((lower..higher + 1).collect())
}
/// Checks to see if there is a continuous range of integers, starting at the
@@ -477,8 +480,7 @@ fn contract_protocol_list<'a>(supported_set: &'a HashSet<u32>) -> String {
fn parse_protocols_from_string_with_no_validation<'a>(
protocol_string: &'a str,
) -> Result<HashMap<String, HashSet<u32>>, &'static str> {
- let protocols = &protocol_string.split(" ")
- .collect::<Vec<&'a str>>()[..];
+ let protocols = &protocol_string.split(" ").collect::<Vec<&'a str>>()[..];
let mut parsed: HashMap<String, HashSet<u32>> = HashMap::new();
diff --git a/src/rust/protover/tests/protover.rs b/src/rust/protover/tests/protover.rs
index 7d8484ecc2..af7633a484 100644
--- a/src/rust/protover/tests/protover.rs
+++ b/src/rust/protover/tests/protover.rs
@@ -1,7 +1,7 @@
extern crate protover;
#[test]
-fn parse_protocol_list_with_single_protocol_and_single_version_returns_set_of_one(){
+fn parse_protocol_list_with_single_proto_and_single_version() {
let protocol = "Cons=1";
let (is_supported, unsupported) = protover::all_supported(protocol);
assert_eq!(true, is_supported);
@@ -9,7 +9,7 @@ fn parse_protocol_list_with_single_protocol_and_single_version_returns_set_of_on
}
#[test]
-fn parse_protocol_list_with_single_protocol_and_multiple_versions_returns_set_of_one(){
+fn parse_protocol_list_with_single_protocol_and_multiple_versions() {
let protocol = "Cons=1-2";
let (is_supported, unsupported) = protover::all_supported(protocol);
assert_eq!(true, is_supported);
@@ -17,7 +17,7 @@ fn parse_protocol_list_with_single_protocol_and_multiple_versions_returns_set_of
}
#[test]
-fn parse_protocol_list_with_different_single_protocol_and_single_version_returns_set_of_one(){
+fn parse_protocol_list_with_different_single_protocol_and_single_version() {
let protocol = "HSDir=1";
let (is_supported, unsupported) = protover::all_supported(protocol);
assert_eq!(true, is_supported);
@@ -25,7 +25,7 @@ fn parse_protocol_list_with_different_single_protocol_and_single_version_returns
}
#[test]
-fn parse_protocol_list_with_single_protocol_and_supported_version_returns_set_of_one(){
+fn parse_protocol_list_with_single_protocol_and_supported_version() {
let protocol = "Desc=2";
let (is_supported, unsupported) = protover::all_supported(protocol);
assert_eq!(true, is_supported);
@@ -33,7 +33,7 @@ fn parse_protocol_list_with_single_protocol_and_supported_version_returns_set_of
}
#[test]
-fn parse_protocol_list_with_two_protocols_and_single_version_returns_set_of_one(){
+fn parse_protocol_list_with_two_protocols_and_single_version() {
let protocols = "Cons=1 HSDir=1";
let (is_supported, unsupported) = protover::all_supported(protocols);
assert_eq!(true, is_supported);
@@ -42,7 +42,7 @@ fn parse_protocol_list_with_two_protocols_and_single_version_returns_set_of_one(
#[test]
-fn parse_protocol_list_with_single_protocol_and_two_nonsequential_versions_returns_set_of_two(){
+fn parse_protocol_list_with_single_protocol_and_two_nonsequential_versions() {
let protocol = "Desc=1,2";
let (is_supported, unsupported) = protover::all_supported(protocol);
assert_eq!(true, is_supported);
@@ -51,7 +51,7 @@ fn parse_protocol_list_with_single_protocol_and_two_nonsequential_versions_retur
#[test]
-fn parse_protocol_list_with_single_protocol_and_two_sequential_versions_returns_set_of_two(){
+fn parse_protocol_list_with_single_protocol_and_two_sequential_versions() {
let protocol = "Desc=1-2";
let (is_supported, unsupported) = protover::all_supported(protocol);
assert_eq!(true, is_supported);
@@ -169,7 +169,7 @@ fn protover_string_supports_protocol_returns_false_for_single_unsupported() {
}
#[test]
-fn protover_string_supports_protocol_returns_false_when_protocol_name_is_not_in_map(){
+fn protover_string_supports_protocol_returns_false_for_unsupported() {
let protocols = "Link=3-4";
let is_supported = protover::protover_string_supports_protocol(
protocols,