diff options
author | George Kadianakis <desnacked@riseup.net> | 2015-04-01 14:33:09 +0100 |
---|---|---|
committer | Nick Mathewson <nickm@torproject.org> | 2015-04-03 09:35:47 -0400 |
commit | 8dba8a088d7c1402831ab5a7211a4a347a60ff7a (patch) | |
tree | c3e34874455b7400f8257031d73e36992c0ff206 /src/or | |
parent | 2bcb596dcf3dd5972de3875da3f1d9485115ce38 (diff) | |
download | tor-8dba8a088d7c1402831ab5a7211a4a347a60ff7a.tar.gz tor-8dba8a088d7c1402831ab5a7211a4a347a60ff7a.zip |
Block multiple introductions on the same intro circuit.
Diffstat (limited to 'src/or')
-rw-r--r-- | src/or/or.h | 3 | ||||
-rw-r--r-- | src/or/rendmid.c | 13 |
2 files changed, 16 insertions, 0 deletions
diff --git a/src/or/or.h b/src/or/or.h index 34f055cf06..4459957a06 100644 --- a/src/or/or.h +++ b/src/or/or.h @@ -3157,6 +3157,9 @@ typedef struct or_circuit_t { * to the specification? */ unsigned int remaining_relay_early_cells : 4; + /* We have already received an INTRODUCE1 cell on this circuit. */ + unsigned int already_received_introduce1 : 1; + /** True iff this circuit was made with a CREATE_FAST cell. */ unsigned int is_first_hop : 1; diff --git a/src/or/rendmid.c b/src/or/rendmid.c index 1bd11f6dc0..2f75ffb204 100644 --- a/src/or/rendmid.c +++ b/src/or/rendmid.c @@ -149,6 +149,19 @@ rend_mid_introduce(or_circuit_t *circ, const uint8_t *request, goto err; } + /* We have already done an introduction on this circuit but we just + received a request for another one. We block it since this might + be an attempt to DoS a hidden service (#15515). */ + if (circ->already_received_introduce1) { + log_fn(LOG_PROTOCOL_WARN, LD_REND, + "Blocking multiple introductions on the same circuit. " + "Someone might be trying to attack a hidden service through " + "this relay."); + goto err; + } + + circ->already_received_introduce1 = 1; + /* We could change this to MAX_HEX_NICKNAME_LEN now that 0.0.9.x is * obsolete; however, there isn't much reason to do so, and we're going * to revise this protocol anyway. |