aboutsummaryrefslogtreecommitdiff
path: root/src/or/shared_random.c
diff options
context:
space:
mode:
authorGeorge Kadianakis <desnacked@riseup.net>2016-05-24 13:58:20 +0300
committerDavid Goulet <dgoulet@torproject.org>2016-07-01 14:01:41 -0400
commitebbff3174059f0c1d0fb51a39f97de453ea055f4 (patch)
tree66fc4e274605937672d171b15a9a88f59a96b211 /src/or/shared_random.c
parentf6f4668b1d0dec1a9afc25ef9d7fcd884cc55608 (diff)
downloadtor-ebbff3174059f0c1d0fb51a39f97de453ea055f4.tar.gz
tor-ebbff3174059f0c1d0fb51a39f97de453ea055f4.zip
prop250: Silence a logging message.
LOG_NOTICE is a bit too much for that one.
Diffstat (limited to 'src/or/shared_random.c')
-rw-r--r--src/or/shared_random.c12
1 files changed, 10 insertions, 2 deletions
diff --git a/src/or/shared_random.c b/src/or/shared_random.c
index 7da6daf62f..599273f066 100644
--- a/src/or/shared_random.c
+++ b/src/or/shared_random.c
@@ -438,7 +438,7 @@ generate_srv(const char *hashed_reveals, uint8_t reveal_num,
/* Debugging. */
char srv_hash_encoded[SR_SRV_VALUE_BASE64_LEN + 1];
sr_srv_encode(srv_hash_encoded, sizeof(srv_hash_encoded), srv);
- log_debug(LD_DIR, "SR: Generated SRV: %s", srv_hash_encoded);
+ log_info(LD_DIR, "SR: Generated SRV: %s", srv_hash_encoded);
}
return srv;
}
@@ -617,7 +617,15 @@ should_keep_commit(const sr_commit_t *commit, const char *voter_key,
case SR_PHASE_COMMIT:
/* Already having a commit for an authority so ignore this one. */
if (saved_commit) {
- log_debug(LD_DIR, "SR: Ignoring known commit during COMMIT phase.");
+ /* Receiving known commits should happen naturally since commit phase
+ lasts multiple rounds. However if the commitment value changes
+ during commit phase, it might be a bug so log more loudly. */
+ if (!commitments_are_the_same(commit, saved_commit)) {
+ log_info(LD_DIR, "SR: Received altered commit from %s in commit phase.",
+ sr_commit_get_rsa_fpr(commit));
+ } else {
+ log_debug(LD_DIR, "SR: Ignoring known commit during commit phase.");
+ }
goto ignore;
}