diff options
| author | Nick Mathewson <nickm@torproject.org> | 2012-12-13 17:34:05 -0500 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2012-12-13 17:34:05 -0500 |
| commit | b1ff8daeb521d1645bc35ffd7191599b7169c2bb (patch) | |
| tree | 60c365a6cb8f67cb2abbf92cc7e504a282974713 /src/or/routerlist.c | |
| parent | 579808d4cdc62346fffa364900d0d76cfa28b3e1 (diff) | |
| download | tor-b1ff8daeb521d1645bc35ffd7191599b7169c2bb.tar.gz tor-b1ff8daeb521d1645bc35ffd7191599b7169c2bb.zip | |
Nuke uses of memcmp outside of unit tests
We want to be saying fast_mem{cmp,eq,neq} when we're doing a
comparison that's allowed to exit early, or tor_mem{cmp,eq,neq} when
we need a data-invariant timing. Direct use of memcmp tends to imply
that we haven't thought about the issue.
Diffstat (limited to 'src/or/routerlist.c')
| -rw-r--r-- | src/or/routerlist.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/or/routerlist.c b/src/or/routerlist.c index 5536d1c61b..6fff70b6b2 100644 --- a/src/or/routerlist.c +++ b/src/or/routerlist.c @@ -4436,7 +4436,7 @@ update_consensus_router_descriptor_downloads(time_t now, int is_vote, sd->signed_descriptor_digest, DIGEST_LEN)) { /* We have a descriptor with this digest, but either there is no * entry in routerlist with the same ID (!ri), or there is one, - * but the identity digest differs (memcmp). + * but the identity digest differs (memneq). */ smartlist_add(no_longer_old, sd); ++n_in_oldrouters; /* We have it in old_routers. */ |