summaryrefslogtreecommitdiff
path: root/src/or/routerlist.c
diff options
context:
space:
mode:
authorRoger Dingledine <arma@torproject.org>2007-05-20 14:15:23 +0000
committerRoger Dingledine <arma@torproject.org>2007-05-20 14:15:23 +0000
commitddd0054a8504f274e3cf16d6728b8b052e0c8a49 (patch)
tree10316521a4602884e10f3c176b77cc328362da0a /src/or/routerlist.c
parent0b661f65759408af19fbd30587deffc0bc3163d8 (diff)
downloadtor-ddd0054a8504f274e3cf16d6728b8b052e0c8a49.tar.gz
tor-ddd0054a8504f274e3cf16d6728b8b052e0c8a49.zip
point out two remote crash bugs, a memory leak, and a few other
items we should probably look into. svn:r10227
Diffstat (limited to 'src/or/routerlist.c')
-rw-r--r--src/or/routerlist.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/src/or/routerlist.c b/src/or/routerlist.c
index 2aab834df4..82117f0d2c 100644
--- a/src/or/routerlist.c
+++ b/src/or/routerlist.c
@@ -4857,6 +4857,8 @@ routerinfo_incompatible_with_extrainfo(routerinfo_t *ri, extrainfo_t *ei)
if (ei->bad_sig)
return 1;
+ /* XXX020 below we should explain why this is strcmp and not strcasecmp,
+ * since it differs from how we usually compare nicknames. -RD */
if (strcmp(ri->nickname, ei->nickname) ||
memcmp(ri->cache_info.identity_digest, ei->cache_info.identity_digest,
DIGEST_LEN))