summaryrefslogtreecommitdiff
path: root/src/or/rendservice.c
diff options
context:
space:
mode:
authorNick Mathewson <nickm@torproject.org>2014-08-21 12:14:00 -0400
committerNick Mathewson <nickm@torproject.org>2014-08-21 12:14:00 -0400
commita8cc41a2303b9f6c8cffa6b69cd759760d91226e (patch)
treeb2ea640cf66dff29384314784c03577f19dfcd61 /src/or/rendservice.c
parent916fba2243f36dcf53b078a95ce2389a63b94f72 (diff)
parent523587a5cf62119baa01822e2e783925726a790b (diff)
downloadtor-a8cc41a2303b9f6c8cffa6b69cd759760d91226e.tar.gz
tor-a8cc41a2303b9f6c8cffa6b69cd759760d91226e.zip
Merge branch 'coverity_20140821'
Diffstat (limited to 'src/or/rendservice.c')
-rw-r--r--src/or/rendservice.c8
1 files changed, 2 insertions, 6 deletions
diff --git a/src/or/rendservice.c b/src/or/rendservice.c
index 629e42cdf2..0633c35fbb 100644
--- a/src/or/rendservice.c
+++ b/src/or/rendservice.c
@@ -1446,10 +1446,7 @@ rend_service_introduce(origin_circuit_t *circuit, const uint8_t *request,
memwipe(hexcookie, 0, sizeof(hexcookie));
/* Free the parsed cell */
- if (parsed_req) {
- rend_service_free_intro(parsed_req);
- parsed_req = NULL;
- }
+ rend_service_free_intro(parsed_req);
/* Free rp if we must */
if (need_rp_free) extend_info_free(rp);
@@ -1539,7 +1536,6 @@ void
rend_service_free_intro(rend_intro_cell_t *request)
{
if (!request) {
- log_info(LD_BUG, "rend_service_free_intro() called with NULL request!");
return;
}
@@ -1648,7 +1644,7 @@ rend_service_begin_parse_intro(const uint8_t *request,
goto done;
err:
- if (rv) rend_service_free_intro(rv);
+ rend_service_free_intro(rv);
rv = NULL;
if (err_msg_out && !err_msg) {
tor_asprintf(&err_msg,