diff options
author | Mike Perry <mikeperry-git@fscked.org> | 2012-12-18 12:39:03 -0800 |
---|---|---|
committer | Mike Perry <mikeperry-git@fscked.org> | 2012-12-18 13:26:36 -0800 |
commit | b0fc18c37e0d30d9941109382df4b2b44f0f0ff8 (patch) | |
tree | 0ea76767b653d2238c039de678fc5929b3a862e5 /src/or/relay.c | |
parent | ccaeef22e168af34e9b6a63d65ce17e58dd702e2 (diff) | |
download | tor-b0fc18c37e0d30d9941109382df4b2b44f0f0ff8.tar.gz tor-b0fc18c37e0d30d9941109382df4b2b44f0f0ff8.zip |
Changes from Nick's code review 'part 1'
I think this is actually his third code review of this branch so far.
Diffstat (limited to 'src/or/relay.c')
-rw-r--r-- | src/or/relay.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/src/or/relay.c b/src/or/relay.c index b4b77007cd..8b3b27f036 100644 --- a/src/or/relay.c +++ b/src/or/relay.c @@ -698,17 +698,17 @@ connection_ap_process_end_not_open( reason == END_STREAM_REASON_INTERNAL || reason == END_STREAM_REASON_DESTROY) { /* All three of these reasons could mean a failed tag - * hit the exit and it shat itself. Do not probe. + * hit the exit and it complained. Do not probe. * Fail the circuit. */ circ->path_state = PATH_STATE_USE_FAILED; return -END_CIRC_REASON_TORPROTOCOL; } else { /* Path bias: If we get a valid reason code from the exit, - * it wasn't due to tagging */ - // XXX: This relies on recognized+digest being strong enough not - // to be spoofable.. Is that a valid assumption? - // Or more accurately: is it better than nothing? Can the attack - // be done offline? + * it wasn't due to tagging. + * + * We rely on recognized+digest being strong enough to make + * tags unlikely to allow us to get tagged, yet 'recognized' + * reason codes here. */ circ->path_state = PATH_STATE_USE_SUCCEEDED; } } |