summaryrefslogtreecommitdiff
path: root/src/or/onion_tap.c
diff options
context:
space:
mode:
authorNick Mathewson <nickm@torproject.org>2014-03-27 14:15:53 -0400
committerNick Mathewson <nickm@torproject.org>2014-03-27 14:15:53 -0400
commitde9de9e7dd2f34af04c76abf3f51c72dec4bdc93 (patch)
treeaf125f4d2e25a93c82c678c08c7b89d43fef66e3 /src/or/onion_tap.c
parentcd15172444e0f8e34d1adcd84034c40893cd6c0f (diff)
downloadtor-de9de9e7dd2f34af04c76abf3f51c72dec4bdc93.tar.gz
tor-de9de9e7dd2f34af04c76abf3f51c72dec4bdc93.zip
Give specific warnings when client-side onionskin handshakes fail
Fix for bug9635.
Diffstat (limited to 'src/or/onion_tap.c')
-rw-r--r--src/or/onion_tap.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/src/or/onion_tap.c b/src/or/onion_tap.c
index 3782e75abf..9a9f374b93 100644
--- a/src/or/onion_tap.c
+++ b/src/or/onion_tap.c
@@ -194,8 +194,10 @@ onion_skin_TAP_client_handshake(crypto_dh_t *handshake_state,
len = crypto_dh_compute_secret(LOG_PROTOCOL_WARN, handshake_state,
handshake_reply, DH_KEY_LEN, key_material,
key_material_len);
- if (len < 0)
+ if (len < 0) {
+ log_warn(LD_PROTOCOL,"DH computation failed.");
goto err;
+ }
if (tor_memneq(key_material, handshake_reply+DH_KEY_LEN, DIGEST_LEN)) {
/* H(K) does *not* match. Something fishy. */