diff options
| author | teor <teor2345@gmail.com> | 2017-10-15 14:37:32 -0400 |
|---|---|---|
| committer | teor <teor2345@gmail.com> | 2017-12-02 21:21:41 +1100 |
| commit | 9acfd70f26ce8ad10c0b4a68de24121abf503c69 (patch) | |
| tree | be60c0fd6c694cd71f8e445271280152d79f2a6c /src/or/networkstatus.c | |
| parent | cf3da63b9023875e93c05d30fb6d76e047bebe70 (diff) | |
| download | tor-9acfd70f26ce8ad10c0b4a68de24121abf503c69.tar.gz tor-9acfd70f26ce8ad10c0b4a68de24121abf503c69.zip | |
Sprinkle some consts in networkstatus_getinfo_by_purpose()
And note where we change the running flag, but probably shouldn't.
Implements ticket 24489.
Diffstat (limited to 'src/or/networkstatus.c')
| -rw-r--r-- | src/or/networkstatus.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/src/or/networkstatus.c b/src/or/networkstatus.c index 10d9b7542a..eeb72831c1 100644 --- a/src/or/networkstatus.c +++ b/src/or/networkstatus.c @@ -2222,13 +2222,13 @@ networkstatus_getinfo_helper_single(const routerstatus_t *rs) char * networkstatus_getinfo_by_purpose(const char *purpose_string, time_t now) { - time_t cutoff = now - ROUTER_MAX_AGE_TO_PUBLISH; + const time_t cutoff = now - ROUTER_MAX_AGE_TO_PUBLISH; char *answer; routerlist_t *rl = router_get_routerlist(); smartlist_t *statuses; - uint8_t purpose = router_purpose_from_string(purpose_string); + const uint8_t purpose = router_purpose_from_string(purpose_string); routerstatus_t rs; - int bridge_auth = authdir_mode_bridge(get_options()); + const int bridge_auth = authdir_mode_bridge(get_options()); if (purpose == ROUTER_PURPOSE_UNKNOWN) { log_info(LD_DIR, "Unrecognized purpose '%s' when listing router statuses.", @@ -2245,6 +2245,7 @@ networkstatus_getinfo_by_purpose(const char *purpose_string, time_t now) continue; if (ri->purpose != purpose) continue; + /* TODO: modifying the running flag in a getinfo is a bad idea */ if (bridge_auth && ri->purpose == ROUTER_PURPOSE_BRIDGE) dirserv_set_router_is_running(ri, now); /* then generate and write out status lines for each of them */ |