diff options
| author | Nick Mathewson <nickm@torproject.org> | 2011-03-25 16:01:16 -0400 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2011-03-25 18:32:27 -0400 |
| commit | 05887f10ffe14498e96c34d2faa535187719689f (patch) | |
| tree | 15b26c0cd66ecaa447ff2b77de6d4f91b6481e99 /src/or/geoip.c | |
| parent | c4bd067359b07f6a57adf9d444d2a46e514043ff (diff) | |
| download | tor-05887f10ffe14498e96c34d2faa535187719689f.tar.gz tor-05887f10ffe14498e96c34d2faa535187719689f.zip | |
Triage the XXX022 and XXX021 comments remaining in the code
Remove some, postpone others, leave some alone. Now the only
remaining XXX022s are ones that seem important to fix or investigate.
Diffstat (limited to 'src/or/geoip.c')
| -rw-r--r-- | src/or/geoip.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/or/geoip.c b/src/or/geoip.c index 654241c1c0..e41d5e36b8 100644 --- a/src/or/geoip.c +++ b/src/or/geoip.c @@ -601,8 +601,9 @@ _dirreq_map_put(dirreq_map_entry_t *entry, dirreq_type_t type, tor_assert(entry->type == type); tor_assert(entry->dirreq_id == dirreq_id); - /* XXXX022 once we're sure the bug case never happens, we can switch - * to HT_INSERT */ + /* XXXX we could switch this to HT_INSERT some time, since it seems that + * this bug doesn't happen. But since this function doesn't seem to be + * critical-path, it's sane to leave it alone. */ old_ent = HT_REPLACE(dirreqmap, &dirreq_map, entry); if (old_ent && old_ent != entry) { log_warn(LD_BUG, "Error when putting directory request into local " |