Use the new guard notification/selection APIs throughout Tor

This patch doesn't cover every case; omitted cases are marked with
"XXXX prop271", as usual.  It leaves both the old interface and the
new interface for guard status notification, since they don't
actually work in the same way: the new API wants to be told when a
circuit has failed or succeeded, whereas the old API wants to know
when a channel has failed or succeeded.

I ran into some trouble with directory guard stuff, since when we
pick the directory guard, we don't actually have a circuit to
associate it with.  I solved that by allowing guard states to be
associated with directory connections, not just circuits.

1 files changed, 1 insertions, 1 deletions

diff --git a/src/or/entrynodes.h b/src/or/entrynodes.h
index 60191ab8b9..7dcedd6066 100644
--- a/src/or/entrynodes.h
+++ b/src/or/entrynodes.h
@@ -328,7 +328,7 @@ void entry_guard_chan_failed(guard_selection_t *gs,
                             channel_t *chan);
 void entry_guards_update_all(guard_selection_t *gs);
 int entry_guards_upgrade_waiting_circuits(guard_selection_t *gs,
-                                          smartlist_t *all_circuits,
+                                          const smartlist_t *all_circuits,
                                           smartlist_t *newly_complete_out);
 void entry_guards_note_internet_connectivity(guard_selection_t *gs);