diff options
| author | Nick Mathewson <nickm@torproject.org> | 2012-12-13 17:34:05 -0500 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2012-12-13 17:34:05 -0500 |
| commit | b1ff8daeb521d1645bc35ffd7191599b7169c2bb (patch) | |
| tree | 60c365a6cb8f67cb2abbf92cc7e504a282974713 /src/or/dirserv.c | |
| parent | 579808d4cdc62346fffa364900d0d76cfa28b3e1 (diff) | |
| download | tor-b1ff8daeb521d1645bc35ffd7191599b7169c2bb.tar.gz tor-b1ff8daeb521d1645bc35ffd7191599b7169c2bb.zip | |
Nuke uses of memcmp outside of unit tests
We want to be saying fast_mem{cmp,eq,neq} when we're doing a
comparison that's allowed to exit early, or tor_mem{cmp,eq,neq} when
we need a data-invariant timing. Direct use of memcmp tends to imply
that we haven't thought about the issue.
Diffstat (limited to 'src/or/dirserv.c')
| -rw-r--r-- | src/or/dirserv.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/or/dirserv.c b/src/or/dirserv.c index 0eb1fb3c62..d080fe7b1e 100644 --- a/src/or/dirserv.c +++ b/src/or/dirserv.c @@ -2269,7 +2269,7 @@ compare_routerinfo_by_ip_and_bw_(const void **a, const void **b) else if (first->addr > second->addr) return 1; - /* Potentially, this next bit could cause k n lg n memcmp calls. But in + /* Potentially, this next bit could cause k n lg n memeq calls. But in * reality, we will almost never get here, since addresses will usually be * different. */ |