diff options
| author | Nick Mathewson <nickm@torproject.org> | 2014-08-21 10:21:17 -0400 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2014-08-21 10:21:17 -0400 |
| commit | e6a05c1c549dca6e76b900feaee97941c5fb723c (patch) | |
| tree | ef5cc7dc7ccacfc1b12f0aacb38ce62bc9ac0759 /src/or/control.c | |
| parent | 2a0a5fe6123bd87f996814991641cc404601ea55 (diff) | |
| download | tor-e6a05c1c549dca6e76b900feaee97941c5fb723c.tar.gz tor-e6a05c1c549dca6e76b900feaee97941c5fb723c.zip | |
Add a missing goto to an unusable branch and make the branch LD_BUG.
(It's LD_BUG to reach this point because the hashed password values
were tested earlier from options_validate)
[Coverity CID 1232091]
Diffstat (limited to 'src/or/control.c')
| -rw-r--r-- | src/or/control.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/or/control.c b/src/or/control.c index a920ac835e..11a853041b 100644 --- a/src/or/control.c +++ b/src/or/control.c @@ -1160,9 +1160,10 @@ handle_control_authenticate(control_connection_t *conn, uint32_t len, } if (bad) { if (!also_cookie) { - log_warn(LD_CONTROL, + log_warn(LD_BUG, "Couldn't decode HashedControlPassword: invalid base16"); errstr="Couldn't decode HashedControlPassword value in configuration."; + goto err; } bad_password = 1; SMARTLIST_FOREACH(sl, char *, cp, tor_free(cp)); |