summaryrefslogtreecommitdiff
path: root/src/or/control.c
diff options
context:
space:
mode:
authorNick Mathewson <nickm@torproject.org>2014-09-18 11:13:57 -0400
committerNick Mathewson <nickm@torproject.org>2014-09-18 11:13:57 -0400
commit58e813d0fcfcecfc2017255f2d8943cd26a4b2e7 (patch)
tree79c33e4bf8ed7f0a5a8fabeda6595ccec776e09f /src/or/control.c
parentd14127eb7adfb92b1790f0aaa65089cfb6c71094 (diff)
downloadtor-58e813d0fcfcecfc2017255f2d8943cd26a4b2e7.tar.gz
tor-58e813d0fcfcecfc2017255f2d8943cd26a4b2e7.zip
Fix a double-free in failing case of handle_control_authenticate.
Bugfix on ed8f020e205267e6270494634346ab68d830e1d8; bug not in any released version of Tor. Found by Coverity; this is CID 1239290.
Diffstat (limited to 'src/or/control.c')
-rw-r--r--src/or/control.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/src/or/control.c b/src/or/control.c
index 60aa869439..7038b2cfd5 100644
--- a/src/or/control.c
+++ b/src/or/control.c
@@ -1177,6 +1177,7 @@ handle_control_authenticate(control_connection_t *conn, uint32_t len,
});
SMARTLIST_FOREACH(sl, char *, cp, tor_free(cp));
smartlist_free(sl);
+ sl = NULL;
if (used_quoted_string)
errstr = "Password did not match HashedControlPassword value from "