Fix dirserv_get_networkstatus_v2's api: its function comments

did not at all match its behavior, and I can't think of a case
when it should return anything other than 0.

This fix may allow getinfo dir/status/foo to work.


svn:r6285

1 files changed, 2 insertions, 5 deletions

diff --git a/src/or/control.c b/src/or/control.c
index 6357ce9eaf..c8fd631a77 100644
--- a/src/or/control.c
+++ b/src/or/control.c
@@ -1509,11 +1509,8 @@ handle_getinfo_helper(const char *question, char **answer)
     if (!get_options()->DirPort)
       return 0;
     status_list = smartlist_create();
-    if (!dirserv_get_networkstatus_v2(status_list,
-                                      question+strlen("dir/status/"))) {
-      smartlist_free(status_list);
-      return 0;
-    }
+    dirserv_get_networkstatus_v2(status_list,
+                                 question+strlen("dir/status/"));
     len = 0;
     SMARTLIST_FOREACH(status_list, cached_dir_t *, d, len += d->dir_len);
     cp = *answer = tor_malloc(len+1);