diff options
author | Roger Dingledine <arma@torproject.org> | 2009-10-10 13:39:41 -0400 |
---|---|---|
committer | Roger Dingledine <arma@torproject.org> | 2009-10-10 13:39:41 -0400 |
commit | 746a19e84d1abf2804f5b4fd8bc3353b162f854c (patch) | |
tree | 53cfb6480d2fad7a5fe96a803735378000906c8b /src/or/connection_edge.c | |
parent | 047fdd4104800a46db32b043cecf0bc31d59cb70 (diff) | |
download | tor-746a19e84d1abf2804f5b4fd8bc3353b162f854c.tar.gz tor-746a19e84d1abf2804f5b4fd8bc3353b162f854c.zip |
remove some dead code. some of it was tickling coverity.
Diffstat (limited to 'src/or/connection_edge.c')
-rw-r--r-- | src/or/connection_edge.c | 19 |
1 files changed, 0 insertions, 19 deletions
diff --git a/src/or/connection_edge.c b/src/or/connection_edge.c index 0e6297a50a..97d6595e97 100644 --- a/src/or/connection_edge.c +++ b/src/or/connection_edge.c @@ -1547,18 +1547,6 @@ connection_ap_handshake_rewrite_and_attach(edge_connection_t *conn, uint32_t answer; struct in_addr in; /* Reply to resolves immediately if we can. */ - if (strlen(socks->address) > RELAY_PAYLOAD_SIZE) { - log_warn(LD_APP,"Address to be resolved is too large. Failing."); - control_event_client_status(LOG_WARN, "SOCKS_BAD_HOSTNAME HOSTNAME=%s", - escaped(socks->address)); - connection_ap_handshake_socks_resolved(conn, - RESOLVED_TYPE_ERROR_TRANSIENT, - 0,NULL,-1,TIME_MAX); - connection_mark_unattached_ap(conn, - END_STREAM_REASON_SOCKSPROTOCOL | - END_STREAM_REASON_FLAG_ALREADY_SOCKS_REPLIED); - return -1; - } if (tor_inet_aton(socks->address, &in)) { /* see if it's an IP already */ /* leave it in network order */ answer = in.s_addr; @@ -2156,13 +2144,6 @@ connection_ap_handshake_send_resolve(edge_connection_t *ap_conn) tor_assert(payload_len <= (int)sizeof(inaddr_buf)); } - if (payload_len > MAX_SOCKS_ADDR_LEN) { - /* This should be impossible: we don't accept addresses this big. */ - /* XXX Should we log a bug here? */ - connection_mark_unattached_ap(ap_conn, END_STREAM_REASON_INTERNAL); - return -1; - } - log_debug(LD_APP, "Sending relay cell to begin stream %d.", ap_conn->stream_id); |