diff options
| author | Nick Mathewson <nickm@torproject.org> | 2016-06-02 09:46:12 -0400 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2016-06-11 10:11:54 -0400 |
| commit | 53a3b39da1241ba43f63f1515f6ef5167b182cae (patch) | |
| tree | 558ec394f3a02bb8f2b5e887ff70b82231424143 /src/or/connection.c | |
| parent | 80f1a2cbbdd0abd509711a5069f31855df5bcd79 (diff) | |
| download | tor-53a3b39da1241ba43f63f1515f6ef5167b182cae.tar.gz tor-53a3b39da1241ba43f63f1515f6ef5167b182cae.zip | |
Add -Wmissing-variable-declarations, with attendant fixes
This is a big-ish patch, but it's very straightforward. Under this
clang warning, we're not actually allowed to have a global variable
without a previous extern declaration for it. The cases where we
violated this rule fall into three roughly equal groups:
* Stuff that should have been static.
* Stuff that was global but where the extern was local to some
other C file.
* Stuff that was only global when built for the unit tests, that
needed a conditional extern in the headers.
The first two were IMO genuine problems; the last is a wart of how
we build tests.
Diffstat (limited to 'src/or/connection.c')
| -rw-r--r-- | src/or/connection.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/or/connection.c b/src/or/connection.c index 86ed2fbccf..f713bbbe65 100644 --- a/src/or/connection.c +++ b/src/or/connection.c @@ -2697,8 +2697,6 @@ connection_is_rate_limited(connection_t *conn) #ifdef USE_BUFFEREVENTS static struct bufferevent_rate_limit_group *global_rate_limit = NULL; #else -extern int global_read_bucket, global_write_bucket; -extern int global_relayed_read_bucket, global_relayed_write_bucket; /** Did either global write bucket run dry last second? If so, * we are likely to run dry again this second, so be stingy with the |