diff options
| author | Nick Mathewson <nickm@torproject.org> | 2008-02-21 16:12:01 +0000 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2008-02-21 16:12:01 +0000 |
| commit | 0ba2bfeef6a4836dadf88307333806371a611ae1 (patch) | |
| tree | c7efa72ea4619591c172673def1361b4dcf74a1c /src/or/connection.c | |
| parent | e2f25558b9ec2ed70a92026870a46b5b68799ebf (diff) | |
| download | tor-0ba2bfeef6a4836dadf88307333806371a611ae1.tar.gz tor-0ba2bfeef6a4836dadf88307333806371a611ae1.zip | |
r14363@31-33-219: nickm | 2008-02-21 11:11:33 -0500
Answer the next-to-last XXX020rc item.
svn:r13658
Diffstat (limited to 'src/or/connection.c')
| -rw-r--r-- | src/or/connection.c | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/src/or/connection.c b/src/or/connection.c index 891c81a0e7..54edcea73d 100644 --- a/src/or/connection.c +++ b/src/or/connection.c @@ -1860,9 +1860,16 @@ loop_again: /* The other side's handle_write will never actually get called, so * we need to invoke the appropriate callbacks ourself. */ connection_t *linked = conn->linked_conn; - /* XXXX020rc Do we need to ensure that this stuff is called even if + /* XXXX020 Do we need to ensure that this stuff is called even if * conn dies in a way that causes us to return -1 earlier? -NM * No idea. -RD */ + /* Actually, I'm pretty sure not. The big things here are to + * tell the linked connection, "yes, you wrote some stuff!" so that + * it can succeed as a appropriate. But if this side of the link + * returned -1, then it couldn't process the data it got. That's + * fairly rare, and doesn't really count as "success" for the other + * side. -NM + */ if (n_read) { /* Probably a no-op, but hey. */ |