summaryrefslogtreecommitdiff
path: root/src/or/connection.c
diff options
context:
space:
mode:
authorNick Mathewson <nickm@torproject.org>2012-06-15 10:05:21 -0400
committerNick Mathewson <nickm@torproject.org>2012-06-15 15:07:53 -0400
commit783f705ddc507c082ab53b556317680447f046f6 (patch)
tree47b873cf2f26cf3859efdfb34696a905a75eef5e /src/or/connection.c
parent2491fff5a6fda1c1e2044d332e551907a579929d (diff)
downloadtor-783f705ddc507c082ab53b556317680447f046f6.tar.gz
tor-783f705ddc507c082ab53b556317680447f046f6.zip
Document that we are unlikely to underflow session group IDs.
Diffstat (limited to 'src/or/connection.c')
-rw-r--r--src/or/connection.c7
1 files changed, 6 insertions, 1 deletions
diff --git a/src/or/connection.c b/src/or/connection.c
index 9bbab19201..c22068b823 100644
--- a/src/or/connection.c
+++ b/src/or/connection.c
@@ -1048,7 +1048,12 @@ connection_listener_new(const struct sockaddr *listensockaddr,
if (port_cfg->session_group >= 0) {
lis_conn->session_group = port_cfg->session_group;
} else {
- /* XXXX023 This can wrap after ~INT_MAX ports are opened. */
+ /* This can wrap afuter ~INT_MAX listeners are opened. But I don't
+ * believe that matters, since you would need to open a ridiculous
+ * number of listeners while keeping the early ones open before you ever
+ * hit this. An OR with a dozen ports open, for example, would have to
+ * close and re-open its listers every second for 4 years nonstop.
+ */
lis_conn->session_group = global_next_session_group--;
}
}