diff options
| author | Nick Mathewson <nickm@torproject.org> | 2007-02-08 22:07:56 +0000 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2007-02-08 22:07:56 +0000 |
| commit | e00a1cbf16d04f8c66320e599ae383753f590f09 (patch) | |
| tree | ccece7691f4b9ca02e91d723bea266800177f00c /src/or/connection.c | |
| parent | 90b53beec5ba4ea19f144c17a5bbe7936e0c49c5 (diff) | |
| download | tor-e00a1cbf16d04f8c66320e599ae383753f590f09.tar.gz tor-e00a1cbf16d04f8c66320e599ae383753f590f09.zip | |
r11726@catbus: nickm | 2007-02-08 16:04:53 -0500
Resolve some XXXX012 items:
- Remove PathlenCoinWeight: if we want it again, we can add it
back in.
- Ditto with RelayBandwidth*.
- Decide to leave in the "hey, you didn't set end_reason!" BUG log message,
but stop telling people to bug me personally.
- Postpone strengthening assert_connection_ok(): it's important, but
it's also a good way to introduce weird bugs.
- Move some expensive consistency checking from dns_free_all() into
assert_cache_ok().
svn:r9533
Diffstat (limited to 'src/or/connection.c')
| -rw-r--r-- | src/or/connection.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/src/or/connection.c b/src/or/connection.c index 8dcee806e0..5edb5b6572 100644 --- a/src/or/connection.c +++ b/src/or/connection.c @@ -477,9 +477,8 @@ connection_about_to_close_connection(connection_t *conn) conn->marked_for_close_file, conn->marked_for_close); } if (!edge_conn->end_reason) { - // XXXX012 Disable this before 0.1.2.x-final ships. log_warn(LD_BUG,"Bug: Closing stream (marked at %s:%d) without having" - " set end_reason. Please tell Nick.", + " set end_reason.", conn->marked_for_close_file, conn->marked_for_close); } control_event_stream_status(edge_conn, STREAM_EVENT_CLOSED, @@ -2385,7 +2384,7 @@ assert_connection_ok(connection_t *conn, time_t now) if (conn->hold_open_until_flushed) tor_assert(conn->marked_for_close); - /* XXXX012 check: wants_to_read, wants_to_write, s, conn_array_index, + /* XXXX check: wants_to_read, wants_to_write, s, conn_array_index, * marked_for_close. */ /* buffers */ @@ -2394,7 +2393,7 @@ assert_connection_ok(connection_t *conn, time_t now) assert_buf_ok(conn->outbuf); } - /* XXXX012 Fix this; no longer so.*/ + /* XXXX Fix this; no longer so.*/ #if 0 if (conn->type != CONN_TYPE_OR && conn->type != CONN_TYPE_DIR) tor_assert(!conn->pkey); |