aboutsummaryrefslogtreecommitdiff
path: root/src/or/circuituse.c
diff options
context:
space:
mode:
authorRoger Dingledine <arma@torproject.org>2010-09-28 23:27:00 -0400
committerRoger Dingledine <arma@torproject.org>2010-09-28 23:27:00 -0400
commit512433346f01f054e99c2dccede324a41a819fe8 (patch)
tree5e759910fad38a091569e93359467e5febb96498 /src/or/circuituse.c
parent7e644b3f691e44642cc267b62cf49a7e4bffd383 (diff)
downloadtor-512433346f01f054e99c2dccede324a41a819fe8.tar.gz
tor-512433346f01f054e99c2dccede324a41a819fe8.zip
improve code comments, based on comments from nick
Diffstat (limited to 'src/or/circuituse.c')
-rw-r--r--src/or/circuituse.c10
1 files changed, 7 insertions, 3 deletions
diff --git a/src/or/circuituse.c b/src/or/circuituse.c
index f651ef7c33..f369678ab0 100644
--- a/src/or/circuituse.c
+++ b/src/or/circuituse.c
@@ -959,9 +959,13 @@ circuit_build_failed(origin_circuit_t *circ)
if (circ->_base.n_conn) {
or_connection_t *n_conn = circ->_base.n_conn;
if (n_conn->is_bad_for_new_circs) {
- /* no need to blow away circuits/streams/etc. Also, don't mark this
- * router as newly down, since maybe this was just an old circuit
- * attempt that's finally timing out now. */
+ /* We only want to blame this router when a fresh healthy
+ * connection fails. So don't mark this router as newly failed,
+ * since maybe this was just an old circuit attempt that's
+ * finally timing out now. Also, there's no need to blow away
+ * circuits/streams/etc, since the failure of an unhealthy conn
+ * doesn't tell us much about whether a healthy conn would
+ * succeed. */
already_marked = 1;
}
log_info(LD_OR,