diff options
| author | Nick Mathewson <nickm@torproject.org> | 2011-03-25 16:01:16 -0400 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2011-03-25 18:32:27 -0400 |
| commit | 05887f10ffe14498e96c34d2faa535187719689f (patch) | |
| tree | 15b26c0cd66ecaa447ff2b77de6d4f91b6481e99 /src/or/circuituse.c | |
| parent | c4bd067359b07f6a57adf9d444d2a46e514043ff (diff) | |
| download | tor-05887f10ffe14498e96c34d2faa535187719689f.tar.gz tor-05887f10ffe14498e96c34d2faa535187719689f.zip | |
Triage the XXX022 and XXX021 comments remaining in the code
Remove some, postpone others, leave some alone. Now the only
remaining XXX022s are ones that seem important to fix or investigate.
Diffstat (limited to 'src/or/circuituse.c')
| -rw-r--r-- | src/or/circuituse.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/or/circuituse.c b/src/or/circuituse.c index 8d9d115863..607beaa06a 100644 --- a/src/or/circuituse.c +++ b/src/or/circuituse.c @@ -1266,7 +1266,8 @@ circuit_get_open_circ_or_launch(edge_connection_t *conn, return -1; } } else { - /* XXXX022 Duplicates checks in connection_ap_handshake_attach_circuit */ + /* XXXX023 Duplicates checks in connection_ap_handshake_attach_circuit: + * refactor into a single function? */ routerinfo_t *router = router_get_by_nickname(conn->chosen_exit_name, 1); int opt = conn->chosen_exit_optional; if (router && !connection_ap_can_use_exit(conn, router, 0)) { @@ -1605,7 +1606,7 @@ connection_ap_handshake_attach_circuit(edge_connection_t *conn) /* find the circuit that we should use, if there is one. */ retval = circuit_get_open_circ_or_launch( conn, CIRCUIT_PURPOSE_C_GENERAL, &circ); - if (retval < 1) // XXX021 if we totally fail, this still returns 0 -RD + if (retval < 1) // XXX022 if we totally fail, this still returns 0 -RD return retval; log_debug(LD_APP|LD_CIRC, |