diff options
| author | Mike Perry <mikeperry-git@fscked.org> | 2012-12-09 19:18:04 -0800 |
|---|---|---|
| committer | Mike Perry <mikeperry-git@fscked.org> | 2012-12-09 19:18:04 -0800 |
| commit | 930fbb2fec2b0c4e56cc4f10f8faec9d0d135274 (patch) | |
| tree | c445c95119f07c68a498dcdaa06db8e546f81ef7 /src/or/circuitbuild.c | |
| parent | 686fc222593fd46ec82d62f0fa62ca02900c1014 (diff) | |
| download | tor-930fbb2fec2b0c4e56cc4f10f8faec9d0d135274.tar.gz tor-930fbb2fec2b0c4e56cc4f10f8faec9d0d135274.zip | |
Flag cannibalized circs as used (non-ideal).
Also add some comments.
Diffstat (limited to 'src/or/circuitbuild.c')
| -rw-r--r-- | src/or/circuitbuild.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/src/or/circuitbuild.c b/src/or/circuitbuild.c index c3a5827589..7282d57c74 100644 --- a/src/or/circuitbuild.c +++ b/src/or/circuitbuild.c @@ -1219,6 +1219,10 @@ pathbias_count_first_hop(origin_circuit_t *circ) return 0; } + // XXX: Technically, we could make this only count from the *second* hop.. + // Until we get per-hop MACs or a lower circ failure rate, this might be + // better from a false positive POV. Should we s/first_hop/circ_attempt/g? + // Then we can control this check from the consensus. if (circ->cpath->state == CPATH_STATE_AWAITING_KEYS) { /* Help track down the real cause of bug #6475: */ if (circ->has_opened && circ->path_state != PATH_STATE_DID_FIRST_HOP) { |