summaryrefslogtreecommitdiff
path: root/src/or/circuitbuild.c
diff options
context:
space:
mode:
authorGeorge Kadianakis <desnacked@gmail.com>2011-09-23 17:50:56 +0200
committerGeorge Kadianakis <desnacked@gmail.com>2011-09-23 17:50:56 +0200
commite2703e36545babce19cd248299a5a12cdd11dff2 (patch)
treee4305f8d244bb096ea2b27332de88d55da59bc85 /src/or/circuitbuild.c
parent2e73f9b3eeb37d0307197e48ed62e1def40e44a8 (diff)
downloadtor-e2703e36545babce19cd248299a5a12cdd11dff2.tar.gz
tor-e2703e36545babce19cd248299a5a12cdd11dff2.zip
Improve wording in some comments and log messages.
Diffstat (limited to 'src/or/circuitbuild.c')
-rw-r--r--src/or/circuitbuild.c10
1 files changed, 5 insertions, 5 deletions
diff --git a/src/or/circuitbuild.c b/src/or/circuitbuild.c
index 86154bac2e..ddd7931e68 100644
--- a/src/or/circuitbuild.c
+++ b/src/or/circuitbuild.c
@@ -4675,7 +4675,8 @@ transport_resolve_conflicts(transport_t *t)
we either have duplicate torrc lines OR we are here post-HUP and
this transport was here pre-HUP as well. In any case, mark the
old transport so that it doesn't get removed and ignore the new
- one.
+ one. Our caller has to free the new transport so we return '1' to
+ signify this.
If there is already a transport with the same name but different
addrport:
@@ -4703,8 +4704,8 @@ transport_resolve_conflicts(transport_t *t)
transport_free(t_tmp);
} else { /* *not* marked for removal */
log_notice(LD_GENERAL, "You tried to add transport '%s' at '%s:%u' "
- "which already exists at '%s:%u'. Skipping.", t->name,
- fmt_addr(&t->addr), t->port,
+ "but the same transport already exists at '%s:%u'. "
+ "Skipping.", t->name, fmt_addr(&t->addr), t->port,
fmt_addr(&t_tmp->addr), t_tmp->port);
return -1;
}
@@ -4731,10 +4732,9 @@ transport_add(transport_t *t)
case 0: /* should register transport */
if (!transport_list)
transport_list = smartlist_create();
-
smartlist_add(transport_list, t);
return 0;
- default: /* should let the caller know the return code */
+ default: /* let our caller know the return code */
return r;
}
}