diff options
| author | teor <teor@torproject.org> | 2019-09-26 13:31:32 +1000 |
|---|---|---|
| committer | teor <teor@torproject.org> | 2019-09-30 22:03:59 +1000 |
| commit | 4c88ebcf4728084cad0a1f177eb9cdb107388581 (patch) | |
| tree | 02abc542b9d1f9627b70f953b837b926e6665ad4 /src/lib | |
| parent | de66bed604377db23cfa303b83e385ef59121a64 (diff) | |
| download | tor-4c88ebcf4728084cad0a1f177eb9cdb107388581.tar.gz tor-4c88ebcf4728084cad0a1f177eb9cdb107388581.zip | |
log: Remove duplicate code and an outdated comment
Preparation for 31854.
Diffstat (limited to 'src/lib')
| -rw-r--r-- | src/lib/log/log.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/src/lib/log/log.c b/src/lib/log/log.c index d2002f6eae..994fdbdd9e 100644 --- a/src/lib/log/log.c +++ b/src/lib/log/log.c @@ -584,8 +584,7 @@ logv,(int severity, log_domain_mask_t domain, const char *funcname, /* check that severity is sane. Overrunning the masks array leads to * interesting and hard to diagnose effects */ raw_assert(severity >= LOG_ERR && severity <= LOG_DEBUG); - /* check that we've initialised the log mutex before we try to lock it */ - raw_assert(log_mutex_initialized); + LOCK_LOGS(); if ((! (domain & LD_NOCB)) && pending_cb_messages @@ -866,9 +865,6 @@ logs_close_sigsafe(void) * logfiles (it is probably present, but it might not be due to thread * racing issues). After this function is called, the caller shouldn't * refer to <b>victim</b> anymore. - * - * Long-term, we need to do something about races in the log subsystem - * in general. See bug 222 for more details. */ static void delete_log(logfile_t *victim) |