diff options
| author | Alexander Færøy <ahf@torproject.org> | 2022-11-01 10:45:17 +0100 |
|---|---|---|
| committer | Alexander Færøy <ahf@torproject.org> | 2022-11-01 11:11:20 +0100 |
| commit | 75d12dffe707d6861485092e0a87db6384a87252 (patch) | |
| tree | 5d93ed540c04528f3e54a906f50639d18771f45e /src/lib | |
| parent | c733ccda996238d28c8068e7c9e7af95f5573547 (diff) | |
| download | tor-75d12dffe707d6861485092e0a87db6384a87252.tar.gz tor-75d12dffe707d6861485092e0a87db6384a87252.zip | |
Remove `BUG()` in Windows process read callback.
This BUG() was added when the code was written to see if this callback
was ever executed after we marked the handle as EOF. It turns out, it
does, but we handle it gracefully. We can therefore remove the BUG().
Fixes tpo/core/tor#40596.
Diffstat (limited to 'src/lib')
| -rw-r--r-- | src/lib/process/process_win32.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/lib/process/process_win32.c b/src/lib/process/process_win32.c index dfcb17a480..6458f93752 100644 --- a/src/lib/process/process_win32.c +++ b/src/lib/process/process_win32.c @@ -888,7 +888,7 @@ process_win32_read_from_handle(process_win32_handle_t *handle, /* Check if we have been asked to read from a handle that have already told * us that we have reached the end of the file. */ - if (BUG(handle->reached_eof)) + if (handle->reached_eof) return 0; /* This cast should be safe since our buffer can be at maximum up to |