diff options
author | Nick Mathewson <nickm@torproject.org> | 2019-10-01 09:42:10 -0400 |
---|---|---|
committer | Nick Mathewson <nickm@torproject.org> | 2019-10-01 09:45:12 -0400 |
commit | 39640728c332980daf7ca639827735a1c359669a (patch) | |
tree | bc8104a221760d32ec7d7c48b958d5d349cceb6b /src/lib/log | |
parent | 53116ca0b71898b46a6d678407fb1b03c2ab8a93 (diff) | |
download | tor-39640728c332980daf7ca639827735a1c359669a.tar.gz tor-39640728c332980daf7ca639827735a1c359669a.zip |
Add comments to try to prevent recurrence of #31495.
There is a bad design choice in two of our configuration types,
where the empty string encodes a value that is not the same as the
default value. This design choice, plus an implementation mistake,
meant that config_dup() did not preserve the value of routerset_t,
and thereby caused bug #31495.
This comment-only patch documents the two types with the problem,
and suggests that implementors try to avoid it in the future.
Closes ticket 31907.
Diffstat (limited to 'src/lib/log')
0 files changed, 0 insertions, 0 deletions