aboutsummaryrefslogtreecommitdiff
path: root/src/feature/rend
diff options
context:
space:
mode:
authorNick Mathewson <nickm@torproject.org>2018-12-20 08:36:25 -0500
committerNick Mathewson <nickm@torproject.org>2018-12-20 08:36:25 -0500
commita517daa56f5848d25ba79617a1a7b82ed2b0a7c0 (patch)
tree88bddb2445449578fefd399ed73a46435113bf2c /src/feature/rend
parent973a5db80851838e4516de40afe028bc10c425f0 (diff)
downloadtor-a517daa56f5848d25ba79617a1a7b82ed2b0a7c0.tar.gz
tor-a517daa56f5848d25ba79617a1a7b82ed2b0a7c0.zip
base32_decode(): Return number of bytes written on success.
This makes it consistent with base64_decode(). Closes ticket 28913.
Diffstat (limited to 'src/feature/rend')
-rw-r--r--src/feature/rend/rendcache.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/src/feature/rend/rendcache.c b/src/feature/rend/rendcache.c
index b851e71959..ecd85e4a5a 100644
--- a/src/feature/rend/rendcache.c
+++ b/src/feature/rend/rendcache.c
@@ -854,7 +854,7 @@ rend_cache_store_v2_desc_as_client(const char *desc,
*entry = NULL;
}
if (base32_decode(want_desc_id, sizeof(want_desc_id),
- desc_id_base32, strlen(desc_id_base32)) != 0) {
+ desc_id_base32, strlen(desc_id_base32)) < 0) {
log_warn(LD_BUG, "Couldn't decode base32 %s for descriptor id.",
escaped_safe_str_client(desc_id_base32));
goto err;
@@ -1005,4 +1005,3 @@ rend_cache_store_v2_desc_as_client(const char *desc,
tor_free(intro_content);
return retval;
}
-