Replace several C identifiers for ticket 18106.

We used to have a single boolean, "FascistFirewall".  Ages ago, in
tickets #17840 and #9067, we added an improved "ReachableAddresses"
mechanism.  It's time to rename related identifiers in the code for
consistency.  This closes #18106.

This is an automated commit, generated by this command:

./scripts/maint/rename_c_identifier.py \
        fascist_firewall_allows_address reachable_addr_allows \
        fascist_firewall_use_ipv6 reachable_addr_use_ipv6 \
        fascist_firewall_prefer_ipv6_impl reachable_addr_prefer_ipv6_impl \
        fascist_firewall_prefer_ipv6_orport reachable_addr_prefer_ipv6_orport \
        fascist_firewall_prefer_ipv6_dirport reachable_addr_prefer_ipv6_dirport \
        fascist_firewall_allows_address_addr reachable_addr_allows_addr \
        fascist_firewall_allows_address_ap reachable_addr_allows_ap \
        fascist_firewall_allows_base reachable_addr_allows_base \
        fascist_firewall_allows_ri_impl reachable_addr_allows_ri_impl \
        fascist_firewall_allows_rs_impl reachable_addr_allows_rs_impl \
        fascist_firewall_allows_rs reachable_addr_allows_rs \
        fascist_firewall_allows_md_impl reachable_addr_allows_md_impl \
        fascist_firewall_allows_node reachable_addr_allows_node \
        fascist_firewall_allows_dir_server reachable_addr_allows_dir_server \
        fascist_firewall_choose_address_impl reachable_addr_choose_impl \
        fascist_firewall_choose_address reachable_addr_choose \
        fascist_firewall_choose_address_base reachable_addr_choose_base \
        fascist_firewall_choose_address_rs reachable_addr_choose_from_rs \
        fascist_firewall_choose_address_ls reachable_addr_choose_from_ls \
        fascist_firewall_choose_address_node reachable_addr_choose_from_node \
        fascist_firewall_choose_address_dir_server reachable_addr_choose_from_dir_server

1 files changed, 3 insertions, 3 deletions

diff --git a/src/feature/rend/rendservice.c b/src/feature/rend/rendservice.c
index 8e1a22fb39..68dd8f4f4a 100644
--- a/src/feature/rend/rendservice.c
+++ b/src/feature/rend/rendservice.c
@@ -1849,13 +1849,13 @@ rend_service_use_direct_connection(const or_options_t* options,
                                    const extend_info_t* ei)
 {
   /* We'll connect directly all reachable addresses, whether preferred or not.
-   * The prefer_ipv6 argument to fascist_firewall_allows_address_addr is
+   * The prefer_ipv6 argument to reachable_addr_allows_addr is
    * ignored, because pref_only is 0. */
   const tor_addr_port_t *ap = extend_info_get_orport(ei, AF_INET);
   if (!ap)
     return 0;
   return (rend_service_allow_non_anonymous_connection(options) &&
-          fascist_firewall_allows_address_addr(&ap->addr, ap->port,
+          reachable_addr_allows_addr(&ap->addr, ap->port,
                                                FIREWALL_OR_CONNECTION, 0, 0));
 }
 
@@ -1867,7 +1867,7 @@ rend_service_use_direct_connection_node(const or_options_t* options,
   /* We'll connect directly all reachable addresses, whether preferred or not.
    */
   return (rend_service_allow_non_anonymous_connection(options) &&
-          fascist_firewall_allows_node(node, FIREWALL_OR_CONNECTION, 0));
+          reachable_addr_allows_node(node, FIREWALL_OR_CONNECTION, 0));
 }
 
 /******