diff options
| author | David Goulet <dgoulet@torproject.org> | 2022-07-26 11:18:15 -0400 |
|---|---|---|
| committer | David Goulet <dgoulet@torproject.org> | 2022-07-26 11:56:33 -0400 |
| commit | b7f9a24c08de435a54424caeb8dbc3916faca96c (patch) | |
| tree | fb3d5d3041eac5b3e0662fe9a3d44aabb43b9ffb /src/feature/relay | |
| parent | da52d7206a4a8e4fa8b5e80b5ed73de50fbe8692 (diff) | |
| download | tor-b7f9a24c08de435a54424caeb8dbc3916faca96c.tar.gz tor-b7f9a24c08de435a54424caeb8dbc3916faca96c.zip | |
relay: Remove unused conn->ext_or_conn_id
This also incidently removes a use of uninitialized stack data from the
connection_or_set_ext_or_identifier() function.
Fixes #40648
Signed-off-by: David Goulet <dgoulet@torproject.org>
Diffstat (limited to 'src/feature/relay')
| -rw-r--r-- | src/feature/relay/ext_orport.c | 13 | ||||
| -rw-r--r-- | src/feature/relay/ext_orport.h | 4 |
2 files changed, 0 insertions, 17 deletions
diff --git a/src/feature/relay/ext_orport.c b/src/feature/relay/ext_orport.c index 3dd884932e..89b287b0b4 100644 --- a/src/feature/relay/ext_orport.c +++ b/src/feature/relay/ext_orport.c @@ -656,19 +656,6 @@ connection_ext_or_start_auth(or_connection_t *or_conn) return 0; } -/** Creates an Extended ORPort identifier for <b>conn</b> and deposits - * it into the global list of identifiers. */ -void -connection_or_set_ext_or_identifier(or_connection_t *conn) -{ - char random_id[EXT_OR_CONN_ID_LEN]; - - if (!conn->ext_or_conn_id) - conn->ext_or_conn_id = tor_malloc_zero(EXT_OR_CONN_ID_LEN); - - memcpy(conn->ext_or_conn_id, random_id, EXT_OR_CONN_ID_LEN); -} - /** Free any leftover allocated memory of the ext_orport.c subsystem. */ void ext_orport_free_all(void) diff --git a/src/feature/relay/ext_orport.h b/src/feature/relay/ext_orport.h index 722dc3787c..5a9063d005 100644 --- a/src/feature/relay/ext_orport.h +++ b/src/feature/relay/ext_orport.h @@ -35,7 +35,6 @@ int connection_ext_or_start_auth(or_connection_t *or_conn); -void connection_or_set_ext_or_identifier(or_connection_t *conn); int connection_ext_or_finished_flushing(or_connection_t *conn); int connection_ext_or_process_inbuf(or_connection_t *or_conn); char *get_ext_or_auth_cookie_file_name(void); @@ -67,9 +66,6 @@ connection_ext_or_process_inbuf(or_connection_t *conn) tor_assert_nonfatal_unreached(); return -1; } -#define connection_or_set_ext_or_identifier(conn) \ - ((void)(conn)) - #define get_ext_or_auth_cookie_file_name() \ (NULL) |